Add multiprocess test helper functions.

base/test/multiprocess_test_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/test/multiprocess_test.h"
 
 #include <unistd.h>
 
 #include "base/containers/hash_tables.h"
 #include "base/logging.h"
 #include "testing/multiprocess_func_list.h"
 
 namespace base {
 
 // A very basic implementation for Android. On Android tests can run in an APK
 // and we don't have an executable to exec*. This implementation does the bare
 // minimum to execute the method specified by procname (in the child process).
+//  - |base_command_line| is ignored.
 //  - All options except |fds_to_remap| are ignored.
 //  - |debug_on_start| is ignored.
-ProcessHandle MultiProcessTest::SpawnChildWithOptions(
+ProcessHandle SpawnMultiProcessTestChild(
     const std::string& procname,
+    const CommandLine& /*base_command_line*/,

[Paweł Hajdan Jr., 2014/03/07 02:08:01]

nit: Why comment out parameter names?

[viettrungluu, 2014/03/07 04:42:44]

Removed, though I believe the style guide permits these.

There are two reasons:
- signal intent (i.e., that it's intentionally not used), while retaining
documentary value (of the parameter name)
- prevent warnings, if the code is ever compiled with the unused-parameter
warning enabled

E.g., here it makes it clear that this implementation is total b.s. and ignores
lots of things that it shouldn't.

     const LaunchOptions& options,
-    bool debug_on_start) {
-  // TODO(vtl): The FD-remapping done below is wrong in the presence of cycles
-  // (e.g., fd1 -> fd2, fd2 -> fd1). crbug.com/326576
+    bool /*debug_on_start*/) {
+  // TODO(viettrungluu): The FD-remapping done below is wrong in the presence of
+  // cycles (e.g., fd1 -> fd2, fd2 -> fd1). crbug.com/326576
   FileHandleMappingVector empty;
   const FileHandleMappingVector* fds_to_remap =
       options.fds_to_remap ? options.fds_to_remap : ∅
 
   pid_t pid = fork();
 
   if (pid < 0) {
     PLOG(ERROR) << "fork";
     return kNullProcessHandle;
   }
@@ skipping 22 matching lines @@
     if (dup2(old_fd, new_fd) < 0) {
       PLOG(FATAL) << "dup2";
     }
     close(old_fd);
   }
   _exit(multi_process_function_list::InvokeChildProcessTest(procname));
   return 0;
 }
 
 }  // namespace base