Add multiprocess test helper functions.

base/test/multiprocess_test.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/test/multiprocess_test.h"
 
 #include "base/base_switches.h"
 #include "base/command_line.h"
 
 namespace base {
 
+#if !defined(OS_ANDROID)
+ProcessHandle SpawnMultiProcessTestChild(
+    const std::string& procname,
+    const CommandLine& base_command_line,
+    const LaunchOptions& options,
+    bool debug_on_start) {
+  CommandLine command_line(base_command_line);
+  command_line.AppendSwitchASCII(switches::kTestChildProcess, procname);
+  if (debug_on_start)
+    command_line.AppendSwitch(switches::kDebugOnStart);
+
+  ProcessHandle handle = kNullProcessHandle;
+  LaunchProcess(command_line, options, &handle);
+  return handle;
+}
+#endif

[Paweł Hajdan Jr., 2014/03/07 02:08:01]

nit:   // !defined(OS_ANDROID)

[viettrungluu, 2014/03/07 04:42:44]

Done, but note that these are generally considered optional if the #if-#endif
block is small and there's no risk of confusion.

+
+CommandLine GetMultiProcessTestChildBaseCommandLine() {
+  return *CommandLine::ForCurrentProcess();
+}
+
+// MultiProcessTest ------------------------------------------------------------
+
 MultiProcessTest::MultiProcessTest() {
 }
 
 ProcessHandle MultiProcessTest::SpawnChild(const std::string& procname,
                                            bool debug_on_start) {
   LaunchOptions options;
 #if defined(OS_WIN)
   options.start_hidden = true;
 #endif
   return SpawnChildWithOptions(procname, options, debug_on_start);
 }
 
-#if !defined(OS_ANDROID)
 ProcessHandle MultiProcessTest::SpawnChildWithOptions(
     const std::string& procname,
     const LaunchOptions& options,
     bool debug_on_start) {
-  ProcessHandle handle = kNullProcessHandle;
-  LaunchProcess(MakeCmdLine(procname, debug_on_start), options, &handle);
-  return handle;
+  return SpawnMultiProcessTestChild(procname,
+                                    MakeCmdLine(procname, debug_on_start),
+                                    options,
+                                    debug_on_start);
 }
-#endif
 
-CommandLine MultiProcessTest::MakeCmdLine(const std::string& procname,
-                                          bool debug_on_start) {
-  CommandLine cl(*CommandLine::ForCurrentProcess());
-  cl.AppendSwitchASCII(switches::kTestChildProcess, procname);
-  if (debug_on_start)
-    cl.AppendSwitch(switches::kDebugOnStart);
-  return cl;
+CommandLine MultiProcessTest::MakeCmdLine(const std::string& /*procname*/,

[Paweł Hajdan Jr., 2014/03/07 02:08:01]

nit: AFAIK we don't comment out parameter names.

[viettrungluu, 2014/03/07 04:42:44]

Removed. <shrug>

+                                          bool /*debug_on_start*/) {
+  return GetMultiProcessTestChildBaseCommandLine();
 }
 
 }  // namespace base