Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 1893713002: S390: Optimize decoding opcode format by using format table (Closed)

Created:
4 years, 8 months ago by john.yan
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Optimize decoding opcode format by using format table R=joransiu@ca.ibm.com, mbrandy@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/4037fd50e752d80cb30c7479b8ce0d67a735f759 Cr-Commit-Position: refs/heads/master@{#35546}

Patch Set 1 #

Patch Set 2 : remove comment #

Patch Set 3 : Add comment to table #

Unified diffs Side-by-side diffs Delta from patch set Stats (+265 lines, -34 lines) Patch
M src/s390/constants-s390.h View 1 3 chunks +4 lines, -34 lines 0 comments Download
M src/s390/constants-s390.cc View 1 2 1 chunk +261 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
john.yan
PTAL
4 years, 8 months ago (2016-04-15 20:40:53 UTC) #1
JoranSiu
On 2016/04/15 20:40:53, john.yan wrote: > PTAL lgtm
4 years, 8 months ago (2016-04-15 20:58:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893713002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893713002/40001
4 years, 8 months ago (2016-04-15 21:00:18 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-16 06:46:26 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-16 06:47:14 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4037fd50e752d80cb30c7479b8ce0d67a735f759
Cr-Commit-Position: refs/heads/master@{#35546}

Powered by Google App Engine
This is Rietveld 408576698