Issue 1893683003: Update the gen command to not fail on generator flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1893683003: Update the gen command to not fail on generator flags. (Closed)

Created:
4 years, 8 months ago by azani

Modified:
4 years, 8 months ago

Reviewers:
vardhan

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Update the gen command to not fail on generator flags. R=vardhan@google.com, vardhan Committed: https://chromium.googlesource.com/external/mojo/+/41bc07e64de0ec96a6c028bcafd60ea4634391e5

Patch Set 1 #

Total comments: 1

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -4 lines)			Patch
M	mojo/dart/packages/_mojo_for_test_only/lib/test/echo_service.mojom.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/public/tools/bindings/mojom_tool/bin/linux64/mojom.sha1	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/public/tools/bindings/mojom_tool/bin/mac64/mojom.sha1	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojom/mojom_parser/gen_cmd.go	View	1 chunk	+3 lines, -1 line	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

vardhan

lgtm https://codereview.chromium.org/1893683003/diff/1/mojom/mojom_parser/gen_cmd.go File mojom/mojom_parser/gen_cmd.go (right): https://codereview.chromium.org/1893683003/diff/1/mojom/mojom_parser/gen_cmd.go#newcode101 mojom/mojom_parser/gen_cmd.go:101: // the message provided for users. that's unfortunate

4 years, 8 months ago (2016-04-15 22:53:35 UTC) #2

azani

4 years, 8 months ago (2016-04-16 00:31:53 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
41bc07e64de0ec96a6c028bcafd60ea4634391e5 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages