Fix _ExecuteOobeApi for non-string arguments.

Fix _ExecuteOobeApi for non-string arguments.

https://codereview.chromium.org/1767443002 broke the PFQ because False was
getting sent as 'False', which JavaScript treats as true.

BUG=chromium:586195
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/7f35a3f99d178e5d86510e266f67d6b9d2de6546

[jdufault, 2016-04-15 19:46:47]

Description was changed from

==========
Fix _ExecuteOobeApi for non-string arguments.

https://codereview.chromium.org/1767443002 broke the PFQ because False was
getting sent as 'False', which JavaScript treats as true.

BUG=chromium:586195
==========

to

==========
Fix _ExecuteOobeApi for non-string arguments.

https://codereview.chromium.org/1767443002 broke the PFQ because False was
getting sent as 'False', which JavaScript treats as true.

BUG=chromium:586195
==========

[jdufault, 2016-04-15 19:46:47]

jdufault@chromium.org changed reviewers:
+ achuith@chromium.org

[jdufault, 2016-04-15 19:47:23]

Achuith, PTAL. Thanks!

[achuithb, 2016-04-15 21:42:19]

lgtm

https://codereview.chromium.org/1893683002/diff/1/telemetry/telemetry/interna...
File telemetry/telemetry/internal/backends/chrome/oobe.py (right):

https://codereview.chromium.org/1893683002/diff/1/telemetry/telemetry/interna...
telemetry/telemetry/internal/backends/chrome/oobe.py:45: js = "{}(" + ('{},' *
len(args)).rstrip(',') + ')'
Any reason to not use single quotes for "{}("?

Let's add a comment that says what js would typically look like, I believe
something like: {}({}, {}, {}), right?

These 2 lines are very dense and difficult to read.

[jdufault, 2016-04-15 21:58:48]

https://codereview.chromium.org/1893683002/diff/1/telemetry/telemetry/interna...
File telemetry/telemetry/internal/backends/chrome/oobe.py (right):

https://codereview.chromium.org/1893683002/diff/1/telemetry/telemetry/interna...
telemetry/telemetry/internal/backends/chrome/oobe.py:45: js = "{}(" + ('{},' *
len(args)).rstrip(',') + ')'
On 2016/04/15 21:42:18, achuithb wrote:
> Any reason to not use single quotes for "{}("?
> 
> Let's add a comment that says what js would typically look like, I believe
> something like: {}({}, {}, {}), right?
> 
> These 2 lines are very dense and difficult to read.

Done.

[achuithb, 2016-04-15 22:05:37]

lgtm

https://codereview.chromium.org/1893683002/diff/20001/telemetry/telemetry/int...
File telemetry/telemetry/internal/backends/chrome/oobe.py (right):

https://codereview.chromium.org/1893683002/diff/20001/telemetry/telemetry/int...
telemetry/telemetry/internal/backends/chrome/oobe.py:49: #   js.format(...):
'doLogin("username","pass",true)'
Thanks!

[jdufault, 2016-04-15 22:09:09]

The CQ bit was checked by jdufault@chromium.org

[commit-bot: I haz the power, 2016-04-15 22:09:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1893683002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1893683002/20001

[commit-bot: I haz the power, 2016-04-15 22:32:33]

Description was changed from

==========
Fix _ExecuteOobeApi for non-string arguments.

https://codereview.chromium.org/1767443002 broke the PFQ because False was
getting sent as 'False', which JavaScript treats as true.

BUG=chromium:586195
==========

to

==========
Fix _ExecuteOobeApi for non-string arguments.

https://codereview.chromium.org/1767443002 broke the PFQ because False was
getting sent as 'False', which JavaScript treats as true.

BUG=chromium:586195

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-04-15 22:32:34]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...