Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1624)

Issue 1893673004: Ensure RemoteFontFaceSource doesn't try to start a load in a detached document (Closed)

Created:
4 years, 8 months ago by Nate Chapin
Modified:
4 years, 8 months ago
Reviewers:
Mike West
CC:
blink-reviews, chromium-reviews, gavinp+loader_chromium.org, kinuko+watch, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org, Yoav Weiss
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure RemoteFontFaceSource doesn't try to start a load in a detached document BUG=603428 Committed: https://crrev.com/fa123915549f2be2b85ed62f2a43ab1b8c5aace1 Cr-Commit-Position: refs/heads/master@{#387718}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -4 lines) Patch
M third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp View 3 chunks +37 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp View 4 chunks +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/weburl_loader_mock.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Nate Chapin
mkwst: Does this seem reasonable? I'm planning on refactoring to make this mistake more difficult ...
4 years, 8 months ago (2016-04-15 21:06:36 UTC) #2
Mike West
LGTM to fix the crasher, though I agree that it's a bit awkward. The other ...
4 years, 8 months ago (2016-04-15 21:21:09 UTC) #3
Nate Chapin
On 2016/04/15 21:21:09, Mike West wrote: > LGTM to fix the crasher, though I agree ...
4 years, 8 months ago (2016-04-15 21:24:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893673004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893673004/1
4 years, 8 months ago (2016-04-15 21:25:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 22:12:59 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 22:14:49 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa123915549f2be2b85ed62f2a43ab1b8c5aace1
Cr-Commit-Position: refs/heads/master@{#387718}

Powered by Google App Engine
This is Rietveld 408576698