Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1893663002: Add ability to default incoming image data as sRGB by default. (Closed)

Created:
4 years, 8 months ago by herb_g
Modified:
4 years, 8 months ago
Reviewers:
reed1
CC:
reviews_skia.org, f(malita), msarett
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change default to linear. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M src/codec/SkCodecImageGenerator.cpp View 1 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
herb_g
4 years, 8 months ago (2016-04-15 19:18:15 UTC) #4
reed1
https://codereview.chromium.org/1893663002/diff/1/src/codec/SkCodecImageGenerator.cpp File src/codec/SkCodecImageGenerator.cpp (right): https://codereview.chromium.org/1893663002/diff/1/src/codec/SkCodecImageGenerator.cpp#newcode29 src/codec/SkCodecImageGenerator.cpp:29: SkColorProfileType profileType = kSRGB_SkColorProfileType; should we start out linear?
4 years, 8 months ago (2016-04-15 19:22:38 UTC) #5
herb_g
Change default to linear.
4 years, 8 months ago (2016-04-15 19:37:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893663002/20001
4 years, 8 months ago (2016-04-15 19:38:07 UTC) #8
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 8 months ago (2016-04-15 19:38:08 UTC) #9
herb_g
https://codereview.chromium.org/1893663002/diff/1/src/codec/SkCodecImageGenerator.cpp File src/codec/SkCodecImageGenerator.cpp (right): https://codereview.chromium.org/1893663002/diff/1/src/codec/SkCodecImageGenerator.cpp#newcode29 src/codec/SkCodecImageGenerator.cpp:29: SkColorProfileType profileType = kSRGB_SkColorProfileType; On 2016/04/15 19:22:38, reed1 wrote: ...
4 years, 8 months ago (2016-04-15 19:38:55 UTC) #10
reed1
lgtm
4 years, 8 months ago (2016-04-15 19:50:11 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 19:57:45 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/4d1061cff656fa82a5d6595eb903b45b9393b638

Powered by Google App Engine
This is Rietveld 408576698