Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1893613002: Implement TypeParameterElementForLink.location. (Closed)

Created:
4 years, 8 months ago by Paul Berry
Modified:
4 years, 8 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement TypeParameterElementForLink.location. This is needed because when comparing function types for equality, we sometimes substitute in a fresh TypeParameterTypeImpl (see FunctionTypeImpl.operator==()). This means that we will sometimes be doing equality comparisons between TypeParameterTypeImpl and TypeParameterElementForLink. TypeParameterTypeImpl.operator==() uses Element.location to do the comparison. R=brianwilkerson@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/eb6a8fda627ca9b22ca61c13a768ea3b41ed5396

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -23 lines) Patch
M pkg/analyzer/lib/src/summary/link.dart View 18 chunks +70 lines, -23 lines 0 comments Download
M pkg/analyzer/test/src/summary/linker_test.dart View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years, 8 months ago (2016-04-15 15:44:49 UTC) #2
scheglov
LGTM
4 years, 8 months ago (2016-04-15 15:47:40 UTC) #3
Brian Wilkerson
lgtm
4 years, 8 months ago (2016-04-15 15:47:40 UTC) #4
Paul Berry
4 years, 8 months ago (2016-04-15 15:51:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
eb6a8fda627ca9b22ca61c13a768ea3b41ed5396 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698