git_map_branches.py - Issue 1893563002: Use CLs more consistently instead of branch names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: git_map_branches.py

Issue 1893563002: Use CLs more consistently instead of branch names (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: fix git map-branches -vv Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: git_map_branches.py

diff --git a/git_map_branches.py b/git_map_branches.py

index 016a0330f732a9e76286c79fdea08ef4ed10ec33..9c7ed1afb348eccf6b19b7164cb029f59db0b4cd 100755

--- a/git_map_branches.py

+++ b/git_map_branches.py

@@ -137,8 +137,9 @@ class BranchMapper(object):

for _ in xrange(len(self.__branches_info)):

# This is a blocking get which waits for the remote CL status to be

# retrieved.

- (branch, url, status) = status_info.next()

- self.__status_info[branch] = (url, color_for_status(status))

+ (cl, status) = status_info.next()

+ self.__status_info[cl.GetBranchRef()] = (cl.GetIssueURL(),

tandrii(chromium) 2016/04/26 09:49:51 It used to be called 'branch' not branchref. Are y

+ color_for_status(status))

roots = set()

« git_cl.py ('K') | « git_cl.py ('k') | no next file » | no next file with comments »