src/compiler/simplified-lowering.cc - Issue 1893543004: [turbofan] JSTypeOf, JSStrictEqual, JSStrictNotEqual and JSToBoolean are pure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/simplified-lowering.cc

Issue 1893543004: [turbofan] JSTypeOf, JSStrictEqual, JSStrictNotEqual and JSToBoolean are pure. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Really disable all broken tests. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/simplified-lowering.cc

diff --git a/src/compiler/simplified-lowering.cc b/src/compiler/simplified-lowering.cc

index 176a9ea7408887607e17e92fd81cad4512894759..57919df72bc2cad4221a56189075a3d182d61b84 100644

--- a/src/compiler/simplified-lowering.cc

+++ b/src/compiler/simplified-lowering.cc

@@ -1044,7 +1044,7 @@ class RepresentationSelector {

flags, properties);

node->InsertInput(jsgraph_->zone(), 0,

jsgraph_->HeapConstant(callable.code()));

- node->InsertInput(jsgraph_->zone(), 3, jsgraph_->NoContextConstant());

+ node->AppendInput(jsgraph_->zone(), jsgraph_->NoContextConstant());

NodeProperties::ChangeOp(node, jsgraph_->common()->Call(desc));

}

break;

@@ -1061,7 +1061,7 @@ class RepresentationSelector {

flags, properties);

node->InsertInput(jsgraph_->zone(), 0,

jsgraph_->HeapConstant(callable.code()));

- node->InsertInput(jsgraph_->zone(), 3, jsgraph_->NoContextConstant());

+ node->AppendInput(jsgraph_->zone(), jsgraph_->NoContextConstant());

NodeProperties::ChangeOp(node, jsgraph_->common()->Call(desc));

}

break;

@@ -1080,7 +1080,7 @@ class RepresentationSelector {

flags, properties);

node->InsertInput(jsgraph_->zone(), 0,

jsgraph_->HeapConstant(callable.code()));

- node->InsertInput(jsgraph_->zone(), 3, jsgraph_->NoContextConstant());

+ node->AppendInput(jsgraph_->zone(), jsgraph_->NoContextConstant());

NodeProperties::ChangeOp(node, jsgraph_->common()->Call(desc));

}

break;

« no previous file with comments | « src/compiler/js-typed-lowering.cc ('k') | src/compiler/simplified-operator.cc » ('j') | no next file with comments »