Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1893543004: [turbofan] JSTypeOf, JSStrictEqual, JSStrictNotEqual and JSToBoolean are pure. (Closed)

Created:
4 years, 8 months ago by Benedikt Meurer
Modified:
4 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] JSTypeOf, JSStrictEqual, JSStrictNotEqual and JSToBoolean are pure. These operators are really pure on the JavaScript level, and were only part of the effect chain to make sure we don't accidentially schedule them right after raw allocations, which is no longer an issue since we now have the concept of atomic regions. R=jarin@chromium.org Committed: https://crrev.com/662caac9d2247e3812eb1c7010728b82450021d0 Cr-Commit-Position: refs/heads/master@{#35552}

Patch Set 1 #

Patch Set 2 : Blacklist failing tests. #

Patch Set 3 : REBASE #

Patch Set 4 : Really disable all broken tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -109 lines) Patch
M src/compiler/js-call-reducer.cc View 4 chunks +8 lines, -13 lines 0 comments Download
M src/compiler/js-operator.cc View 1 2 3 chunks +9 lines, -9 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 6 chunks +4 lines, -35 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/simplified-operator.cc View 3 chunks +4 lines, -17 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M test/unittests/compiler/js-operator-unittest.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 2 9 chunks +17 lines, -26 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
Benedikt Meurer
4 years, 8 months ago (2016-04-15 13:46:59 UTC) #1
Benedikt Meurer
Hey Jaro, Here's some cleanup for the JS level pure operators. Please take a look. ...
4 years, 8 months ago (2016-04-15 13:47:33 UTC) #2
Jarin
lgtm
4 years, 8 months ago (2016-04-15 13:49:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893543004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893543004/1
4 years, 8 months ago (2016-04-15 13:56:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893543004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893543004/20001
4 years, 8 months ago (2016-04-15 13:59:46 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/builds/233) v8_linux_arm64_rel_ng_triggered on tryserver.v8 (JOB_FAILED, ...
4 years, 8 months ago (2016-04-15 14:29:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893543004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893543004/40001
4 years, 8 months ago (2016-04-16 18:33:46 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893543004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893543004/60001
4 years, 8 months ago (2016-04-16 19:03:29 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-16 19:27:09 UTC) #17
commit-bot: I haz the power
4 years, 8 months ago (2016-04-16 19:28:18 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/662caac9d2247e3812eb1c7010728b82450021d0
Cr-Commit-Position: refs/heads/master@{#35552}

Powered by Google App Engine
This is Rietveld 408576698