Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 1893503003: Add new coverage_skia.isolate (Closed)

Created:
4 years, 8 months ago by rmistry
Modified:
4 years, 8 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add new coverage_skia.isolate Coverage is different from the other recipes because it needs both skia_repo and test artifacts. The primary reason is: the path to the out directory is compiled into the binary, which is why the compile and test steps need to be combined. The isolate file will be used from the updated coverage recipe in https://codereview.chromium.org/1862713002/ BUG=skia:5159 NOTREECHECKS=true Committed: https://skia.googlesource.com/skia/+/eff1920debe3991f440a91a8c4b6298ff9ccddc4

Patch Set 1 : Initial upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
A infra/bots/coverage_skia.isolate View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893503003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893503003/1
4 years, 8 months ago (2016-04-15 14:13:00 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-15 14:29:11 UTC) #4
rmistry
4 years, 8 months ago (2016-04-15 14:33:44 UTC) #6
borenet
LGTM
4 years, 8 months ago (2016-04-15 15:34:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893503003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893503003/1
4 years, 8 months ago (2016-04-18 10:49:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893503003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893503003/1
4 years, 8 months ago (2016-04-18 11:12:54 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 11:13:52 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/eff1920debe3991f440a91a8c4b6298ff9ccddc4

Powered by Google App Engine
This is Rietveld 408576698