Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1893483003: [turbofan] Quickfix for fround built-in lowering. (Closed)

Created:
4 years, 8 months ago by Jarin
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Quickfix for fround built-in lowering. We have trouble with Math.fround(MEM[...]). Since we now properly type LoadBuffer (it can produce undefined), lowering of fround has stopped triggering (as it requires Number type). This CL is a quick fix for this issue - we simply trigger the lowering for NumberOrUndefined and let representation selection/truncation analysis deal with this. Ultimately, we would want to insert some 'simplified' ToNumber conversion that would be optimized as much as possible during representation selection. BUG=chromium:603802 LOG=n R=bmeurer@chromium.org Committed: https://crrev.com/71453f1c0f5e402407f6bf5d7c35f52c75cd7eeb Cr-Commit-Position: refs/heads/master@{#35513}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/compiler/js-builtin-reducer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Jarin
Could you take a look, please? (Yes, I do feel ashamed.)
4 years, 8 months ago (2016-04-15 09:31:27 UTC) #1
Benedikt Meurer
Closing my eyes and typing LGTM.
4 years, 8 months ago (2016-04-15 09:32:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893483003/1
4 years, 8 months ago (2016-04-15 09:40:30 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 09:51:20 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 09:52:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71453f1c0f5e402407f6bf5d7c35f52c75cd7eeb
Cr-Commit-Position: refs/heads/master@{#35513}

Powered by Google App Engine
This is Rietveld 408576698