Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 1893473002: Decouple GLHelper from media (Closed)

Created:
4 years, 8 months ago by Fady Samuel
Modified:
4 years, 8 months ago
Reviewers:
piman
CC:
chromium-reviews, posciak+watch_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Decouple GLHelper from media We would like to share GLHelper with Mus. In order to do so, we would like to place this file in gpu/. Thus, it cannot depend on media/. This CL removes the dependency on media::VideoFrame by passing in the stride and data of the Y, U, and V planes into ReadbackYUV instead of passing in a media::VideoFrame. The callers are responsible for keeping media::VideoFrame alive now instead of ReadbackYUV. This CL also moves media::LetterboxYUV to the callers. BUG=601866 Committed: https://crrev.com/59dcea480d282e78805de1c6e15ec29f4ebe7c9d Cr-Commit-Position: refs/heads/master@{#387701}

Patch Set 1 #

Patch Set 2 : Fixed unit tests #

Patch Set 3 : Fixed content_browsertests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -47 lines) Patch
M content/browser/compositor/gl_helper.h View 2 chunks +7 lines, -5 lines 0 comments Download
M content/browser/compositor/gl_helper.cc View 10 chunks +49 lines, -38 lines 0 comments Download
M content/browser/compositor/gl_helper_unittest.cc View 1 2 chunks +12 lines, -1 line 0 comments Download
M content/browser/media/capture/aura_window_capture_machine.cc View 1 2 1 chunk +8 lines, -1 line 0 comments Download
M content/browser/renderer_host/delegated_frame_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/delegated_frame_host.cc View 1 2 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 24 (13 generated)
Fady Samuel
4 years, 8 months ago (2016-04-14 22:55:40 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893473002/1
4 years, 8 months ago (2016-04-14 22:56:55 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/212833)
4 years, 8 months ago (2016-04-14 23:14:38 UTC) #6
piman
lgtm
4 years, 8 months ago (2016-04-14 23:20:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893473002/1
4 years, 8 months ago (2016-04-15 15:02:05 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_dbg/builds/51496)
4 years, 8 months ago (2016-04-15 15:15:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893473002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893473002/20001
4 years, 8 months ago (2016-04-15 17:08:49 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/145590)
4 years, 8 months ago (2016-04-15 17:34:21 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893473002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893473002/40001
4 years, 8 months ago (2016-04-15 20:40:53 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-15 21:27:58 UTC) #22
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 21:29:39 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/59dcea480d282e78805de1c6e15ec29f4ebe7c9d
Cr-Commit-Position: refs/heads/master@{#387701}

Powered by Google App Engine
This is Rietveld 408576698