Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 1893463002: Reland of Use a token to initialise ChannelMojo and MojoApplication everywhere. (Closed)

Created:
4 years, 8 months ago by shrike
Modified:
4 years, 8 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, piman+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Use a token to initialise ChannelMojo and MojoApplication everywhere. (patchset #1 id:1 of https://codereview.chromium.org/1891043002/ ) Reason for revert: Looks like the revert broke the tree :-/. Original issue's description: > Revert of Use a token to initialise ChannelMojo and MojoApplication everywhere. (patchset #5 id:80001 of https://codereview.chromium.org/1880343002/ ) > > Reason for revert: > Suspecting for https://crbug.com/603452. We need to see if reverting this patch fixes tomorrow's Mac Canary. If the problem persists then this cl is not to blame and can be relanded. > > Original issue's description: > > Use a token to initialise ChannelMojo and MojoApplication everywhere. > > > > BUG=None > > > > Committed: https://crrev.com/babb3f34fe20effb72c81104b63b2974271ad88d > > Cr-Commit-Position: refs/heads/master@{#387161} > > TBR=rockot@chromium.org,tsepez@chromium.org,avi@chromium.org,amistry@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=None > > Committed: https://crrev.com/9bda1f9f8f689441f94f95292a74653987bdb0f2 > Cr-Commit-Position: refs/heads/master@{#387437} TBR=rockot@chromium.org,tsepez@chromium.org,avi@chromium.org,amistry@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/4323e22fd52b0efca24759226423b14c46f78ad5 Cr-Commit-Position: refs/heads/master@{#387442}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -333 lines) Patch
M content/browser/gpu/gpu_process_host.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 6 chunks +7 lines, -17 lines 0 comments Download
M content/browser/mojo/mojo_application_host.h View 3 chunks +8 lines, -26 lines 0 comments Download
M content/browser/mojo/mojo_application_host.cc View 2 chunks +10 lines, -61 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 6 chunks +6 lines, -21 lines 0 comments Download
M content/browser/utility_process_host_impl.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M content/child/child_thread_impl.h View 2 chunks +2 lines, -3 lines 0 comments Download
M content/child/child_thread_impl.cc View 5 chunks +7 lines, -9 lines 0 comments Download
M content/child/mojo/mojo_application.h View 1 chunk +7 lines, -25 lines 0 comments Download
M content/child/mojo/mojo_application.cc View 2 chunks +3 lines, -44 lines 0 comments Download
M content/common/content_message_generator.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/in_process_child_thread_params.h View 4 chunks +3 lines, -4 lines 0 comments Download
M content/common/in_process_child_thread_params.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D content/common/mojo/channel_init.h View 1 chunk +0 lines, -41 lines 0 comments Download
D content/common/mojo/channel_init.cc View 1 chunk +0 lines, -32 lines 0 comments Download
D content/common/mojo/mojo_messages.h View 1 chunk +0 lines, -22 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_thread_impl_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/render_thread_impl_browser_test_ipc_helper.h View 3 chunks +8 lines, -4 lines 0 comments Download
M content/test/render_thread_impl_browser_test_ipc_helper.cc View 2 chunks +6 lines, -9 lines 0 comments Download
M ipc/ipc_message_start.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
shrike
Created Reland of Use a token to initialise ChannelMojo and MojoApplication everywhere.
4 years, 8 months ago (2016-04-14 22:10:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893463002/1
4 years, 8 months ago (2016-04-14 22:11:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 22:12:27 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4323e22fd52b0efca24759226423b14c46f78ad5 Cr-Commit-Position: refs/heads/master@{#387442}
4 years, 8 months ago (2016-04-14 22:13:48 UTC) #5
shrike
4 years, 8 months ago (2016-04-14 22:14:02 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1892613003/ by shrike@chromium.org.

The reason for reverting is: The revert broke the tree..

Powered by Google App Engine
This is Rietveld 408576698