Reject port numbers that contain a leading '+' in HttpStreamFactory::ProcessAlternateProtocol().

Reject port numbers that contain a leading '+' in HttpStreamFactory::ProcessAlternateProtocol().

BUG=596565
Committed: https://crrev.com/ad87cd92bcc00ac09aa89a2967e51b82af4da9fb
Cr-Commit-Position: refs/heads/master@{#387663}

[eroman, 2016-04-14 23:13:26]

eroman@chromium.org changed reviewers:
+ mmenke@chromium.org

[eroman, 2016-04-14 23:13:27]

No unit test for this.... because there doesn't appear to be any existing test
for it in net_unittests for me to modify :(

[eroman, 2016-04-14 23:14:14]

Uhm wait I take that back, there definitely are tests for this :)

OK sorry, lemme see if they are easy to modify!

[eroman, 2016-04-15 00:27:16]

PTAL:

Deciding against a unit-test as it was pretty heavy weight, not sure it will be
a benefit to add.

[mmenke, 2016-04-15 14:34:53]

On 2016/04/15 00:27:16, eroman wrote:
> PTAL:
> 
> Deciding against a unit-test as it was pretty heavy weight, not sure it will
be
> a benefit to add.

LGTM.  I agree that unit tests for these things, while nice to have, aren't
necessary, unless there's at least some theoretical exploit / user visible bug.

[eroman, 2016-04-15 17:47:14]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2016-04-15 17:48:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1893433003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1893433003/60001

[commit-bot: I haz the power, 2016-04-15 18:59:10]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-15 19:00:32]

Description was changed from

==========
Reject port numbers that contain a leading '+' in
HttpStreamFactory::ProcessAlternateProtocol().

BUG=596565
==========

to

==========
Reject port numbers that contain a leading '+' in
HttpStreamFactory::ProcessAlternateProtocol().

BUG=596565

Committed: https://crrev.com/ad87cd92bcc00ac09aa89a2967e51b82af4da9fb
Cr-Commit-Position: refs/heads/master@{#387663}
==========

[commit-bot: I haz the power, 2016-04-15 19:00:33]

Patchset 4 (id:??) landed as
https://crrev.com/ad87cd92bcc00ac09aa89a2967e51b82af4da9fb
Cr-Commit-Position: refs/heads/master@{#387663}