Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1893423003: IntersectionObserver: notify when root or target is removed. (Closed)

Created:
4 years, 8 months ago by szager1
Modified:
4 years, 8 months ago
Reviewers:
ojan
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

IntersectionObserver: notify when root or target is removed. If root and target were previously intersecting, and then DOM is modified to remove root or target, or to make target not a containing block descendant of root, send a notification. Merge to M51; original patch: https://codereview.chromium.org/1889053002 BUG=540528 TBR=ojan@chromium.org NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -90 lines) Patch
A + third_party/WebKit/LayoutTests/intersection-observer/remove-element.html View 2 chunks +38 lines, -53 lines 0 comments Download
A + third_party/WebKit/LayoutTests/intersection-observer/remove-element-expected.txt View 1 chunk +22 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObservation.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObservation.cpp View 2 chunks +17 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserver.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893423003/1
4 years, 8 months ago (2016-04-18 18:38:46 UTC) #2
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 18:41:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698