Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 1893403002: Local closures may be the only survivors in a library. (Closed)

Created:
4 years, 8 months ago by rmacnak
Modified:
4 years, 8 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Precompilation: Local functions may be the only survivors in a library. R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/8a14e7588510af5941b2dfe9217bb6af00e08599

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -11 lines) Patch
M runtime/vm/precompiler.h View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/precompiler.cc View 11 chunks +62 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rmacnak
4 years, 8 months ago (2016-04-18 19:21:17 UTC) #3
regis
LGTM
4 years, 8 months ago (2016-04-18 19:32:31 UTC) #4
rmacnak
4 years, 8 months ago (2016-04-18 20:05:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8a14e7588510af5941b2dfe9217bb6af00e08599 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698