Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1893393003: Fix TestURLRequestContext's code to create a ChannelIDService. (Closed)

Created:
4 years, 8 months ago by mmenke
Modified:
4 years, 8 months ago
Reviewers:
nharper
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix TestURLRequestContext's code to create a ChannelIDService. When it created one, it was failing to set it on the HttpNetworkSession. When it was passed one that was already created, it was doing this correctly, which is why it didn't break any tests. BUG=604482 Committed: https://crrev.com/7fc5f25f7b609fec07ae9e3c70315abbcd6313e1 Cr-Commit-Position: refs/heads/master@{#388046}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M net/url_request/url_request_test_util.cc View 2 chunks +12 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mmenke
4 years, 8 months ago (2016-04-18 20:46:35 UTC) #2
nharper
lgtm
4 years, 8 months ago (2016-04-18 20:57:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893393003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893393003/1
4 years, 8 months ago (2016-04-18 20:58:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 22:20:28 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 22:22:10 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7fc5f25f7b609fec07ae9e3c70315abbcd6313e1
Cr-Commit-Position: refs/heads/master@{#388046}

Powered by Google App Engine
This is Rietveld 408576698