Adding support for playback to L32/S32/F16 canvas.

Adding support for playback to L32/S32/F16 canvas.

Playback of my test GM works correctly on both raster and GPU, in all three modes.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1893393002

Committed: https://skia.googlesource.com/skia/+/7831295c63b57efca6e4331b9d66df66985ca805

[Brian Osman, 2016-04-18 15:40:55]

Description was changed from

==========
Adding support for playback to L32/S32/F16 canvas.

Still WIP. Raster can't read directly from BGRA to RGBA_F16, so I had to
introduce a two-step copy. Output of sRGB is different between Raster
and GPU when viewed through the debugger, so something is different from
SampleApp/DM. Added enough safety checks that things don't crash, at
least.

BUG=skia:
==========

to

==========
Adding support for playback to L32/S32/F16 canvas.

Still WIP. Raster can't read directly from BGRA to RGBA_F16, so I had to
introduce a two-step copy. Output of sRGB is different between Raster
and GPU when viewed through the debugger, so something is different from
SampleApp/DM. Added enough safety checks that things don't crash, at
least.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Brian Osman, 2016-04-18 16:00:22]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-18 16:00:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1893393002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1893393002/1

[Brian Osman, 2016-04-18 16:17:02]

brianosman@google.com changed reviewers:
+ ethannicholas@google.com, jcgregorio@google.com, mtklein@google.com

[Brian Osman, 2016-04-18 16:17:03]

Including Mike because of the F16 -> RGBA conversion stuff when massaging the
output for PNG.

https://codereview.chromium.org/1893393002/diff/20001/tools/skiaserve/Request...
File tools/skiaserve/Request.cpp (right):

https://codereview.chromium.org/1893393002/diff/20001/tools/skiaserve/Request...
tools/skiaserve/Request.cpp:46: if (kRGBA_F16_SkColorType ==
canvas->imageInfo().colorType()) {
We have other special-case conversion code in DM, which is actually closer to
what I'd like to do here, but I didn't want to copy-paste all of it. For F16, I
think I'd like to add another case to SkPixelInfo::CopyPixels.

https://codereview.chromium.org/1893393002/diff/20001/tools/skiaserve/Request...
tools/skiaserve/Request.cpp:188: uint32_t flags = cap.fGammaCorrect ?
SkSurfaceProps::kGammaCorrect_Flag : 0;
Need to do this in createCPUSurface, too.

https://codereview.chromium.org/1893393002/diff/20001/tools/skiaserve/urlhand...
File tools/skiaserve/urlhandlers/ColorModeHandler.cpp (right):

https://codereview.chromium.org/1893393002/diff/20001/tools/skiaserve/urlhand...
tools/skiaserve/urlhandlers/ColorModeHandler.cpp:16: bool
ColorModeHandler::canHandle(const char* method, const char* url) {
This is a new file, but (obviously) copied from EnableGPUHandler.cpp. Don't be
fooled by the clever script.

[jcgregorio, 2016-04-18 16:39:30]

https://codereview.chromium.org/1893393002/diff/20001/tools/skiaserve/urlhand...
File tools/skiaserve/urlhandlers/ColorModeHandler.cpp (right):

https://codereview.chromium.org/1893393002/diff/20001/tools/skiaserve/urlhand...
tools/skiaserve/urlhandlers/ColorModeHandler.cpp:33: sscanf(commands[1].c_str(),
"%d", &mode);
Maybe check the return from sscanf?

if (sscanf(commands[1].c_str(), "%d", &mode) != 1) {
   return SendError(connection, "Unable to parse request");
}

[mtklein, 2016-04-18 17:40:48]

https://codereview.chromium.org/1893393002/diff/20001/tools/skiaserve/Request...
File tools/skiaserve/Request.cpp (right):

https://codereview.chromium.org/1893393002/diff/20001/tools/skiaserve/Request...
tools/skiaserve/Request.cpp:46: if (kRGBA_F16_SkColorType ==
canvas->imageInfo().colorType()) {
On 2016/04/18 at 16:17:03, Brian Osman wrote:
> We have other special-case conversion code in DM, which is actually closer to
what I'd like to do here, but I didn't want to copy-paste all of it. For F16, I
think I'd like to add another case to SkPixelInfo::CopyPixels.

Think this is a sign we should fix readPixels() first?

[Brian Osman, 2016-04-19 16:21:39]

Description was changed from

==========
Adding support for playback to L32/S32/F16 canvas.

Still WIP. Raster can't read directly from BGRA to RGBA_F16, so I had to
introduce a two-step copy. Output of sRGB is different between Raster
and GPU when viewed through the debugger, so something is different from
SampleApp/DM. Added enough safety checks that things don't crash, at
least.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Adding support for playback to L32/S32/F16 canvas.

Playback of my test GM works correctly on both raster and GPU, in all three
modes.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Brian Osman, 2016-04-19 16:21:50]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-19 16:21:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1893393002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1893393002/60001

[Brian Osman, 2016-04-19 16:22:58]

Updated to use the code from DM (that is now shared in picture_utils). Fixes all
of the problems with F16 playback, and causes the debugger output to match what
we get in DM and SampleApp in all configs.

[jcgregorio, 2016-04-19 16:24:54]

lgtm

[commit-bot: I haz the power, 2016-04-19 16:31:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 16:31:49]

Dry run: This issue passed the CQ dry run.

[Brian Osman, 2016-04-19 17:15:47]

The CQ bit was checked by brianosman@google.com

[commit-bot: I haz the power, 2016-04-19 17:15:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1893393002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1893393002/60001

[commit-bot: I haz the power, 2016-04-19 17:16:55]

Description was changed from

==========
Adding support for playback to L32/S32/F16 canvas.

Playback of my test GM works correctly on both raster and GPU, in all three
modes.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Adding support for playback to L32/S32/F16 canvas.

Playback of my test GM works correctly on both raster and GPU, in all three
modes.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/7831295c63b57efca6e4331b9d66df66985ca805
==========

[commit-bot: I haz the power, 2016-04-19 17:16:56]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/7831295c63b57efca6e4331b9d66df66985ca805