Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1893383002: Complete separation of CodeAssembler and CodeStubAssembler (Closed)

Created:
4 years, 8 months ago by danno
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com, epertoso
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Complete separation of CodeAssembler and CodeStubAssembler Move allocation-related and smi un/tagging methods into CodeStubAssembler. Committed: https://crrev.com/1f4958de75ea73d728b0b959f2b33b0532edbcd3 Cr-Commit-Position: refs/heads/master@{#35684}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Review feedback #

Patch Set 3 : Review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -193 lines) Patch
M src/code-stub-assembler.h View 1 2 3 chunks +26 lines, -0 lines 0 comments Download
M src/code-stub-assembler.cc View 1 2 3 chunks +153 lines, -0 lines 0 comments Download
M src/compiler/code-assembler.h View 1 2 5 chunks +4 lines, -27 lines 0 comments Download
M src/compiler/code-assembler.cc View 1 2 4 chunks +13 lines, -166 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
danno
PTAL
4 years, 8 months ago (2016-04-18 15:39:15 UTC) #2
Michael Starzinger
LGTM from my end. Benedikt probably has a stronger opinion on this one.
4 years, 8 months ago (2016-04-18 16:36:11 UTC) #3
Benedikt Meurer
LGTM from my side. https://codereview.chromium.org/1893383002/diff/1/src/compiler/code-assembler.h File src/compiler/code-assembler.h (right): https://codereview.chromium.org/1893383002/diff/1/src/compiler/code-assembler.h#newcode195 src/compiler/code-assembler.h:195: Node* BooleanMapConstant(); Maybe these three ...
4 years, 8 months ago (2016-04-18 17:56:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893383002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893383002/40001
4 years, 8 months ago (2016-04-21 06:21:45 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-21 06:45:49 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:14:05 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/1f4958de75ea73d728b0b959f2b33b0532edbcd3
Cr-Commit-Position: refs/heads/master@{#35684}

Powered by Google App Engine
This is Rietveld 408576698