Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1893333006: Use libjpeg-turbo for YUV->RGB conversion in jpeg encoder (Closed)

Created:
4 years, 8 months ago by msarett
Modified:
4 years, 8 months ago
Reviewers:
scroggo, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@m50
Target Ref:
refs/heads/chrome/m50
Project:
skia
Visibility:
Public.

Description

Use libjpeg-turbo for YUV->RGB conversion in jpeg encoder Cherry picked from: https://codereview.chromium.org/1886183002/ """ This remove the previous codepath, which performed a less accurate conversion to YUV. It actually faster to use the more accurate conversion, now that we have updated to libjpeg-turbo. z620 Performance Speed-Up: mandrill.jpg (512x512): 1.13x color_wheel.jpg (128x128): 1.12x This should fix: https://buganizer.corp.google.com/u/0/issues/28161384 https://buganizer.corp.google.com/u/0/issues/21891795 """ BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1893333006 NOTREECHECKS=true NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -111 lines) Patch
M src/images/SkImageDecoder_libjpeg.cpp View 4 chunks +15 lines, -111 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
msarett
FWIW, I needed to cherry-pick this manually. This file name has been changed and tons ...
4 years, 8 months ago (2016-04-18 22:10:00 UTC) #3
djsollen
Now that m50 has gone stable and this isn't chrome related there is no need ...
4 years, 8 months ago (2016-04-19 12:31:10 UTC) #4
msarett
4 years, 8 months ago (2016-04-19 13:07:32 UTC) #5 
sgtm

Powered by Google App Engine
This is Rietveld 408576698