Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Side by Side Diff: third_party/WebKit/Source/core/events/EventTarget.cpp

Issue 1893333004: [DevTools] Bring back InspectorInstrumenetation::didHandleEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
6 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org) 6 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
7 * (C) 2007, 2008 Nikolas Zimmermann <zimmermann@kde.org> 7 * (C) 2007, 2008 Nikolas Zimmermann <zimmermann@kde.org>
8 * 8 *
9 * Redistribution and use in source and binary forms, with or without 9 * Redistribution and use in source and binary forms, with or without
10 * modification, are permitted provided that the following conditions 10 * modification, are permitted provided that the following conditions
(...skipping 421 matching lines...) Expand 10 before | Expand all | Expand 10 after
432 // handling any more events on this target. 432 // handling any more events on this target.
433 if (event->immediatePropagationStopped()) 433 if (event->immediatePropagationStopped())
434 break; 434 break;
435 435
436 ExecutionContext* context = getExecutionContext(); 436 ExecutionContext* context = getExecutionContext();
437 if (!context) 437 if (!context)
438 break; 438 break;
439 439
440 event->setHandlingPassive(registeredListener.passive); 440 event->setHandlingPassive(registeredListener.passive);
441 441
442 InspectorInstrumentation::willHandleEvent(this, event, registeredListene r.listener.get(), registeredListener.useCapture); 442 InspectorInstrumentationCookie cookie = InspectorInstrumentation::willHa ndleEvent(this, event, registeredListener.listener.get(), registeredListener.use Capture);
443 443
444 // To match Mozilla, the AT_TARGET phase fires both capturing and bubbli ng 444 // To match Mozilla, the AT_TARGET phase fires both capturing and bubbli ng
445 // event listeners, even though that violates some versions of the DOM s pec. 445 // event listeners, even though that violates some versions of the DOM s pec.
446 registeredListener.listener->handleEvent(context, event); 446 registeredListener.listener->handleEvent(context, event);
447 event->setHandlingPassive(false); 447 event->setHandlingPassive(false);
448 448
449 RELEASE_ASSERT(i <= size); 449 RELEASE_ASSERT(i <= size);
450
451 InspectorInstrumentation::cancelPauseOnNextStatement(cookie);
450 } 452 }
451 d->firingEventIterators->removeLast(); 453 d->firingEventIterators->removeLast();
452 } 454 }
453 455
454 DispatchEventResult EventTarget::dispatchEventResult(const Event& event) 456 DispatchEventResult EventTarget::dispatchEventResult(const Event& event)
455 { 457 {
456 if (event.defaultPrevented()) 458 if (event.defaultPrevented())
457 return DispatchEventResult::CanceledByEventHandler; 459 return DispatchEventResult::CanceledByEventHandler;
458 if (event.defaultHandled()) 460 if (event.defaultHandled())
459 return DispatchEventResult::CanceledByDefaultEventHandler; 461 return DispatchEventResult::CanceledByDefaultEventHandler;
(...skipping 25 matching lines...) Expand all
485 // they have one less listener to invoke. 487 // they have one less listener to invoke.
486 if (d->firingEventIterators) { 488 if (d->firingEventIterators) {
487 for (size_t i = 0; i < d->firingEventIterators->size(); ++i) { 489 for (size_t i = 0; i < d->firingEventIterators->size(); ++i) {
488 d->firingEventIterators->at(i).iterator = 0; 490 d->firingEventIterators->at(i).iterator = 0;
489 d->firingEventIterators->at(i).end = 0; 491 d->firingEventIterators->at(i).end = 0;
490 } 492 }
491 } 493 }
492 } 494 }
493 495
494 } // namespace blink 496 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698