Issue 189333004: Move more file_util functions to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 189333004: Move more file_util functions to base namespace. (Closed)

Created:
6 years, 9 months ago by brettw

Modified:
6 years, 9 months ago

Reviewers:
jam

CC:
chromium-reviews, asanka, extensions-reviews_chromium.org, alecflett, cmumford, dgrogan, tommycli, benjhayden+dwatch_chromium.org, chrome-apps-syd-reviews_chromium.org, jam, ericu+idb_chromium.org, joi+watch-content_chromium.org, Lei Zhang, darin-cc_chromium.org, Greg Billock, vandebo (ex-Chrome), chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, jsbell+idb_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move more file_util functions to base namespace. TBR=jam Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256863

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+122 lines, -196 lines)			Patch
M	base/file_util.h	View		3 chunks	+28 lines, -36 lines	0 comments	Download
M	base/file_util.cc	View		3 chunks	+4 lines, -15 lines	0 comments	Download
M	base/file_util_linux.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	base/file_util_posix.cc	View	1	3 chunks	+3 lines, -42 lines	0 comments	Download
M	base/file_util_unittest.cc	View		9 chunks	+57 lines, -57 lines	0 comments	Download
M	base/file_util_win.cc	View	1	2 chunks	+2 lines, -18 lines	0 comments	Download
M	base/files/file_path.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/process/process_linux.cc	View	1 2	3 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/download/download_path_reservation_tracker.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/download/download_path_reservation_tracker_unittest.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/external_pref_loader.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/webstore_installer.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/media_galleries/media_folder_finder_unittest.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/web_applications/web_app_win.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	content/browser/download/download_file_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/indexed_db/indexed_db_backing_store.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/indexed_db/indexed_db_factory_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	crypto/nss_util.cc	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

6 years, 9 months ago (2014-03-13 17:26:26 UTC) #2

Message was sent while issue was closed.

Committed patchset #3 manually as r256863 (presubmit successful).

Expand Messages | Collapse Messages