Chromium Code Reviews Chromium Code Reviews
Issue
189333003:
cc: Allow pepper to avoid DCHECK but reuse gpu::Mailbox. (Closed)
Descriptioncc: Allow pepper to avoid DCHECK but reuse gpu::Mailbox.
When setting a texture mailbox on TextureLayer, reusing the same
TextureMailbox is very fishy since the gpu::Mailbox would end up
being released back to the client multiple times.
However since pepper does magical bad things by using a single
texture that somehow is double buffered (this is wrong and
to be fixed), it needs to give the texture to cc multiple times.
It is safer in this case since its ReleaseCallback is empty. We
can encode this with a SetTextureMailboxWithoutReleaseCallback
method on TextureLayer that pepper can use, and it avoids this
DCHECK.
The method comes with a big warning. Pepper should be fixed to
avoid visual tearing, and this method should go away.
R=piman
BUG=350204
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255704
Patch Set 1 #Patch Set 2 : baddcheck: #Patch Set 3 : baddcheck: #Patch Set 4 : baddcheck: compile #
Messages
Total messages: 10 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||
