Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 1893313006: Add control of the sRGB global hack flag in SampleApp (Closed)

Created:
4 years, 8 months ago by Brian Osman
Modified:
4 years, 8 months ago
Reviewers:
herb_g, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M samplecode/SampleApp.cpp View 4 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893313006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893313006/1
4 years, 8 months ago (2016-04-20 15:32:40 UTC) #3
Brian Osman
4 years, 8 months ago (2016-04-20 15:33:15 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-20 15:49:12 UTC) #7
reed1
lgtm
4 years, 8 months ago (2016-04-20 16:18:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893313006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893313006/1
4 years, 8 months ago (2016-04-20 16:19:51 UTC) #10
herb_g
On 2016/04/20 16:18:30, reed1 wrote: > lgtm We need to remember to invalidate at least ...
4 years, 8 months ago (2016-04-20 16:20:37 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-20 16:20:49 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/36db3f44b6cd71d1f462626601ec7c33fdcc187c

Powered by Google App Engine
This is Rietveld 408576698