Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 1893313004: Remove references to and uses of MemberMap (Closed)

Created:
4 years, 8 months ago by Brian Wilkerson
Modified:
4 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+265 lines, -292 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart/override_contributor.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 3 chunks +9 lines, -11 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 27 chunks +96 lines, -74 lines 0 comments Download
M pkg/analyzer/test/generated/inheritance_manager_test.dart View 30 chunks +154 lines, -154 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 2 chunks +0 lines, -47 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
This should be backward compatible.
4 years, 8 months ago (2016-04-19 21:02:37 UTC) #2
scheglov
LGTM
4 years, 8 months ago (2016-04-19 21:07:24 UTC) #3
Brian Wilkerson
4 years, 8 months ago (2016-04-20 14:40:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f3b177e4813f44c5d3f72a059e24f7134f5092f2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698