Fix for node modules

Fix for node modules

We weren't emitting the actual program.  :-)

Seems to work really well - using for easy command line testing.

R=jmesserly@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/663750fec4a614a8410f615af66d4d6d393b8125

[vsm, 2016-04-18 13:31:54]

Description was changed from

==========
Fix for node modules
==========

to

==========
Fix for node modules

We weren't emitting the actual program.  :-)  

Seems to work really well - using for easy command line testing.
==========

[vsm, 2016-04-18 13:31:55]

vsm@google.com changed reviewers:
+ jmesserly@google.com

[vsm, 2016-04-18 13:38:25]

https://codereview.chromium.org/1893293003/diff/20001/lib/src/compiler/module...
File lib/src/compiler/module_builder.dart (right):

https://codereview.chromium.org/1893293003/diff/20001/lib/src/compiler/module...
lib/src/compiler/module_builder.dart:142: var block =
Not entirely sure why I seem to need this.  Without it, it seems js_ast wasn't
renaming colliding identifiers.  I'd get redundant declarations in the SDK:

  const _add = Symbol('_add');
  ...
  const _add = Symbol('_add');

By nesting the whole thing, I'd see:

  const _add = Symbol('_add');
  ...
  const _add$ = Symbol('_add');

Is js_ast not renaming at the top-level?

[Jennifer Messerly, 2016-04-18 20:52:18]

LGTM

https://codereview.chromium.org/1893293003/diff/20001/lib/src/compiler/module...
File lib/src/compiler/module_builder.dart (right):

https://codereview.chromium.org/1893293003/diff/20001/lib/src/compiler/module...
lib/src/compiler/module_builder.dart:142: var block =
On 2016/04/18 13:38:25, vsm wrote:
> Not entirely sure why I seem to need this.  Without it, it seems js_ast wasn't
> renaming colliding identifiers.  I'd get redundant declarations in the SDK:
> 
>   const _add = Symbol('_add');
>   ...
>   const _add = Symbol('_add');
> 
> By nesting the whole thing, I'd see:
> 
>   const _add = Symbol('_add');
>   ...
>   const _add$ = Symbol('_add');
> 
> Is js_ast not renaming at the top-level?

Yeah seems like it's skipping the top-level. That's probably an easy fix though.

Do you mind taking a look? IMO, it'd be good to understand what's going on,
rather than work around it.

Could be a TODO as well. But it'd be nice to keep the technical debt low (I'm
still recovering from the last big cleanup ;)... not to mention our runtime/SDK
debt.)

[vsm, 2016-04-19 21:28:29]

https://codereview.chromium.org/1893293003/diff/20001/lib/src/compiler/module...
File lib/src/compiler/module_builder.dart (right):

https://codereview.chromium.org/1893293003/diff/20001/lib/src/compiler/module...
lib/src/compiler/module_builder.dart:142: var block =
On 2016/04/18 20:52:18, John Messerly wrote:
> On 2016/04/18 13:38:25, vsm wrote:
> > Not entirely sure why I seem to need this.  Without it, it seems js_ast
wasn't
> > renaming colliding identifiers.  I'd get redundant declarations in the SDK:
> > 
> >   const _add = Symbol('_add');
> >   ...
> >   const _add = Symbol('_add');
> > 
> > By nesting the whole thing, I'd see:
> > 
> >   const _add = Symbol('_add');
> >   ...
> >   const _add$ = Symbol('_add');
> > 
> > Is js_ast not renaming at the top-level?
> 
> Yeah seems like it's skipping the top-level. That's probably an easy fix
though.
> 
> Do you mind taking a look? IMO, it'd be good to understand what's going on,
> rather than work around it.
> 
> Could be a TODO as well. But it'd be nice to keep the technical debt low (I'm
> still recovering from the last big cleanup ;)... not to mention our
runtime/SDK
> debt.)

Added a TODO and filed a bug for now.

[vsm, 2016-04-19 21:29:01]

Description was changed from

==========
Fix for node modules

We weren't emitting the actual program.  :-)  

Seems to work really well - using for easy command line testing.
==========

to

==========
Fix for node modules

We weren't emitting the actual program.  :-)

Seems to work really well - using for easy command line testing.

R=jmesserly@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/663750fec4a614a8410f615af66d...
==========

[vsm, 2016-04-19 21:29:03]

Committed patchset #3 (id:40001) manually as
663750fec4a614a8410f615af66d4d6d393b8125 (presubmit successful).