Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: third_party/WebKit/Source/bindings/scripts/v8_methods.py

Issue 1893283004: Leave out redundant includes for postMessage() method bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2013 Google Inc. All rights reserved. 1 # Copyright (C) 2013 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 if is_custom_element_callbacks: 104 if is_custom_element_callbacks:
105 includes.add('core/dom/custom/CustomElementProcessingStack.h') 105 includes.add('core/dom/custom/CustomElementProcessingStack.h')
106 106
107 is_raises_exception = 'RaisesException' in extended_attributes 107 is_raises_exception = 'RaisesException' in extended_attributes
108 is_custom_call_prologue = has_extended_attribute_value(method, 'Custom', 'Ca llPrologue') 108 is_custom_call_prologue = has_extended_attribute_value(method, 'Custom', 'Ca llPrologue')
109 is_custom_call_epilogue = has_extended_attribute_value(method, 'Custom', 'Ca llEpilogue') 109 is_custom_call_epilogue = has_extended_attribute_value(method, 'Custom', 'Ca llEpilogue')
110 is_post_message = 'PostMessage' in extended_attributes 110 is_post_message = 'PostMessage' in extended_attributes
111 if is_post_message: 111 if is_post_message:
112 includes.add('bindings/core/v8/SerializedScriptValueFactory.h') 112 includes.add('bindings/core/v8/SerializedScriptValueFactory.h')
113 includes.add('bindings/core/v8/Transferables.h') 113 includes.add('bindings/core/v8/Transferables.h')
114 includes.add('core/dom/DOMArrayBuffer.h')
115 includes.add('core/dom/MessagePort.h')
116 includes.add('core/frame/ImageBitmap.h')
117 114
118 if 'LenientThis' in extended_attributes: 115 if 'LenientThis' in extended_attributes:
119 raise Exception('[LenientThis] is not supported for operations.') 116 raise Exception('[LenientThis] is not supported for operations.')
120 117
121 argument_contexts = [ 118 argument_contexts = [
122 argument_context(interface, method, argument, index, is_visible=is_visib le) 119 argument_context(interface, method, argument, index, is_visible=is_visib le)
123 for index, argument in enumerate(arguments)] 120 for index, argument in enumerate(arguments)]
124 121
125 return { 122 return {
126 'activity_logging_world_list': v8_utilities.activity_logging_world_list( method), # [ActivityLogging] 123 'activity_logging_world_list': v8_utilities.activity_logging_world_list( method), # [ActivityLogging]
(...skipping 333 matching lines...) Expand 10 before | Expand all | Expand 10 after
460 return method.idl_type and method.idl_type.name == 'Promise' 457 return method.idl_type and method.idl_type.name == 'Promise'
461 458
462 IdlOperation.returns_promise = property(method_returns_promise) 459 IdlOperation.returns_promise = property(method_returns_promise)
463 460
464 461
465 def argument_conversion_needs_exception_state(method, argument): 462 def argument_conversion_needs_exception_state(method, argument):
466 idl_type = argument.idl_type 463 idl_type = argument.idl_type
467 return (idl_type.v8_conversion_needs_exception_state or 464 return (idl_type.v8_conversion_needs_exception_state or
468 argument.is_variadic or 465 argument.is_variadic or
469 (method.returns_promise and idl_type.is_string_type)) 466 (method.returns_promise and idl_type.is_string_type))
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698