Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1893283003: S390: Correctly annotate eval origin. (Closed)

Created:
4 years, 8 months ago by john.yan
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Correctly annotate eval origin. Port 89d7bfda0d3d3ed48a174a2851cfe5da0b31f056 Original commit message: There were a couple of issues with it: - interpreter is not supported - the source position was just accidentally correct for full-codegen - the eval origin could have been cached Also fixes a few other places to use AbstractCode. R=yangguo@chromium.org, joransiu@ca.ibm.com, mbrandy@us.ibm.com, michael_dawson@ca.ibm.com, bjaideep@ca.ibm.com BUG= Committed: https://crrev.com/7d9f917d6502efbf399298ed48c2e8af600a545c Cr-Commit-Position: refs/heads/master@{#35595}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M src/full-codegen/s390/full-codegen-s390.cc View 3 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
john.yan
PTAL
4 years, 8 months ago (2016-04-18 16:51:34 UTC) #2
JoranSiu
On 2016/04/18 16:51:34, john.yan wrote: > PTAL lgtm
4 years, 8 months ago (2016-04-18 17:06:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893283003/1
4 years, 8 months ago (2016-04-18 17:50:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 18:10:21 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 18:11:55 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d9f917d6502efbf399298ed48c2e8af600a545c
Cr-Commit-Position: refs/heads/master@{#35595}

Powered by Google App Engine
This is Rietveld 408576698