Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1022)

Issue 1893273002: Fix string resource for register protocol handler. (Closed)

Created:
4 years, 8 months ago by benwells
Modified:
4 years, 8 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix string resource for register protocol handler. The string resource had a replacement placeholder that was unable to be replaced. BUG=601695 Committed: https://crrev.com/9914498f18f195e38d42de4f1c2a65977056b813 Cr-Commit-Position: refs/heads/master@{#388115}

Patch Set 1 #

Patch Set 2 : Oops get the other one #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
benwells
4 years, 8 months ago (2016-04-18 06:37:45 UTC) #2
Lei Zhang
lgtm
4 years, 8 months ago (2016-04-18 19:18:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893273002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893273002/20001
4 years, 8 months ago (2016-04-19 00:07:56 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-19 01:36:17 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 01:37:38 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9914498f18f195e38d42de4f1c2a65977056b813
Cr-Commit-Position: refs/heads/master@{#388115}

Powered by Google App Engine
This is Rietveld 408576698