Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1893243002: X87: [Interpreter] Make dispatch table point to code entry instead of code objects. (Closed)

Created:
4 years, 8 months ago by zhengxing.li
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [Interpreter] Make dispatch table point to code entry instead of code objects. port 0c05e02f25912c0ce510dac3077be3f72728aa34 (r35480) original commit message: Modifies Ignition to store code entry addresses in the dispatch table rather than code objects. This allows the interpreter to avoid calculating the code entry address from the code object on every dispatch and provides a ~5-7% performance improvement on Octane with Ignition. This change adds ArchOpcode::kArchTailCallAddress to TurboFan to enable tail call dispatch using these code addresses. It also adds a Dispatch linkage creator (distinct from the stub linkage type used previously) to allow targetting a code address target (which will diverge further from the stub linkage type when we remove the context machine register in Ignition). BUG= Committed: https://crrev.com/eb89a753e16ec5ef4794b312d01e23080eae30e0 Cr-Commit-Position: refs/heads/master@{#35561}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/x87/builtins-x87.cc View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 8 months ago (2016-04-18 05:54:18 UTC) #2
Weiliang
lgtm
4 years, 8 months ago (2016-04-18 06:34:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893243002/1
4 years, 8 months ago (2016-04-18 06:35:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 06:56:13 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 06:57:33 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb89a753e16ec5ef4794b312d01e23080eae30e0
Cr-Commit-Position: refs/heads/master@{#35561}

Powered by Google App Engine
This is Rietveld 408576698