Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 1893233003: buildbucket: instrument endpoints with gae_ts_mon (Closed)

Created:
4 years, 8 months ago by nodir
Modified:
4 years, 8 months ago
Reviewers:
Sergey Berezin
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

buildbucket: instrument endpoints with gae_ts_mon Deployed to cr-buildbucket-dev and verified that it sends values. R=sergeyberezin@chromium.org BUG=559500 Committed: https://chromium.googlesource.com/infra/infra/+/a971e1fca1fe5d69bb9cdcddab936b63d72945c9

Patch Set 1 #

Patch Set 2 : specify time fn #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M appengine/cr-buildbucket/api.py View 1 3 chunks +4 lines, -1 line 1 comment Download

Messages

Total messages: 12 (5 generated)
nodir
PTAL
4 years, 8 months ago (2016-04-18 20:02:38 UTC) #1
Sergey Berezin
neat! LGTM.
4 years, 8 months ago (2016-04-18 20:24:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893233003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893233003/1
4 years, 8 months ago (2016-04-18 20:38:43 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: Infra Linux Precise 32 Tester on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Infra%20Linux%20Precise%2032%20Tester/builds/1571)
4 years, 8 months ago (2016-04-18 20:44:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893233003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893233003/20001
4 years, 8 months ago (2016-04-18 21:52:58 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/infra/infra/+/a971e1fca1fe5d69bb9cdcddab936b63d72945c9
4 years, 8 months ago (2016-04-18 21:57:18 UTC) #11
Sergey Berezin
4 years, 8 months ago (2016-04-18 22:45:16 UTC) #12
Message was sent while issue was closed.
https://codereview.chromium.org/1893233003/diff/20001/appengine/cr-buildbucke...
File appengine/cr-buildbucket/api.py (right):

https://codereview.chromium.org/1893233003/diff/20001/appengine/cr-buildbucke...
appengine/cr-buildbucket/api.py:177: fn =
gae_ts_mon.instrument_endpoint(time_fn=ts_mon_time)(fn)
You shouldn't need to specify time here - it's only for testing.

Powered by Google App Engine
This is Rietveld 408576698