third_party/WebKit/LayoutTests/http/tests/webfont/resources/font-load-revalidation-frame.html - Issue 1893233002: WebFonts: reset m_loadLimitState on memory cache revalidation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/webfont/resources/font-load-revalidation-frame.html

Issue 1893233002: WebFonts: reset m_loadLimitState on memory cache revalidation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address hiroshige's comments at #11 Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/http/tests/webfont/font-load-revalidation.html ('K') | « third_party/WebKit/LayoutTests/http/tests/webfont/font-load-revalidation-expected.txt ('k') | third_party/WebKit/Source/core/fetch/FontResource.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <html>

	3 <body>

	4 <div>font loading revalidation test</div>

	5 <script>

	6 // Try to cover the case FontResource is reused even after

	7 // frame.location.reload(). So that memory cache performs revalidation,

	8 // The URL should not have a query like .cgi?delay=100, and HTTP response

	9 // should have at least either Last-modified or Etag header.

	10 var font = new FontFace('Foo', 'url(../cachable-slow-ahem-loading.cgi)', {});

	11 var startTime = performance.now();

	12 font.load();

	13 font.loaded.then(() => {

	14 var loadTime = performance.now() - startTime;

	15 parent.postMessage('pass:font.load()', '*');
	hiroshige 2016/04/21 07:39:10 We don't have lines \|PASS font.load()\| in -expecte We don't have lines \|PASS font.load()\| in -expected.txt. Is it OK? Takashi Toyoshima 2016/04/21 08:31:25 Oops, good point. I forget to update the expectati Oops, good point. I forget to update the expectation after adding this line.
	16 var testName = 'loadTime > 900';

	17 var testResult = loadTime > 900 ? 'pass' : 'fail';

	18 parent.postMessage([testResult, testName].join(':'), '*');

	19 parent.postMessage('reload', '*');

	20 }, () => {

	21 parent.postMessage('fail:font.load()', '*');

	22 });

	23 </script>

	24 </body>

	25 </html>

OLD	NEW