Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1575)

Side by Side Diff: content/browser/accessibility/browser_accessibility_manager_win.cc

Issue 1893213004: Merge to M51: Prevent child frames from sending bad accessibility events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/accessibility/browser_accessibility_manager_win.h" 5 #include "content/browser/accessibility/browser_accessibility_manager_win.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <vector> 10 #include <vector>
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 82
83 IAccessible* BrowserAccessibilityManagerWin::GetParentIAccessible() { 83 IAccessible* BrowserAccessibilityManagerWin::GetParentIAccessible() {
84 BrowserAccessibilityDelegate* delegate = GetDelegateFromRootManager(); 84 BrowserAccessibilityDelegate* delegate = GetDelegateFromRootManager();
85 if (!delegate) 85 if (!delegate)
86 return NULL; 86 return NULL;
87 return delegate->AccessibilityGetNativeViewAccessible(); 87 return delegate->AccessibilityGetNativeViewAccessible();
88 } 88 }
89 89
90 void BrowserAccessibilityManagerWin::MaybeCallNotifyWinEvent( 90 void BrowserAccessibilityManagerWin::MaybeCallNotifyWinEvent(
91 DWORD event, BrowserAccessibility* node) { 91 DWORD event, BrowserAccessibility* node) {
92 BrowserAccessibilityDelegate* delegate = GetDelegateFromRootManager(); 92 BrowserAccessibilityDelegate* delegate =
93 node->manager()->GetDelegateFromRootManager();
93 if (!delegate) { 94 if (!delegate) {
94 // This line and other LOG(WARNING) lines are temporary, to debug 95 // This line and other LOG(WARNING) lines are temporary, to debug
95 // flaky failures in DumpAccessibilityEvent* tests. 96 // flaky failures in DumpAccessibilityEvent* tests.
96 // http://crbug.com/440579 97 // http://crbug.com/440579
97 DLOG(WARNING) << "Not firing AX event because of no delegate"; 98 DLOG(WARNING) << "Not firing AX event because of no delegate";
98 return; 99 return;
99 } 100 }
100 101
101 if (!node->IsNative()) 102 if (!node->IsNative())
102 return; 103 return;
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
335 336
336 void BrowserAccessibilityManagerWin::TrackScrollingObject( 337 void BrowserAccessibilityManagerWin::TrackScrollingObject(
337 BrowserAccessibilityWin* node) { 338 BrowserAccessibilityWin* node) {
338 if (tracked_scroll_object_) 339 if (tracked_scroll_object_)
339 tracked_scroll_object_->Release(); 340 tracked_scroll_object_->Release();
340 tracked_scroll_object_ = node; 341 tracked_scroll_object_ = node;
341 tracked_scroll_object_->AddRef(); 342 tracked_scroll_object_->AddRef();
342 } 343 }
343 344
344 } // namespace content 345 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/accessibility/browser_accessibility_manager.cc ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698