Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1893213002: X87: RESUBMITTING: Bogus assert prevented chromium roll. (Closed)

Created:
4 years, 8 months ago by zhengxing.li
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: RESUBMITTING: Bogus assert prevented chromium roll. port c2de9611281d6da70fe1770072ec55f2f8aaf467(r35440) original commit message: Visit the Optimized Code Map on first call rather than closure creation. This is useful for escape analysis, and helps upcoming changes to type feedback gathering. BUG= Committed: https://crrev.com/095aef6d72d448bdb0110966bce634721f7d6124 Cr-Commit-Position: refs/heads/master@{#35558}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -0 lines) Patch
M src/x87/builtins-x87.cc View 1 chunk +148 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 8 months ago (2016-04-18 02:35:40 UTC) #2
Weiliang
lgtm
4 years, 8 months ago (2016-04-18 03:07:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893213002/1
4 years, 8 months ago (2016-04-18 05:01:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 05:20:11 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 05:21:09 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/095aef6d72d448bdb0110966bce634721f7d6124
Cr-Commit-Position: refs/heads/master@{#35558}

Powered by Google App Engine
This is Rietveld 408576698