Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1893203004: [DevTools] Fix leak in InspectorDatabaseAgent. (Closed)

Created:
4 years, 8 months ago by dgozman
Modified:
4 years, 8 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, blink-reviews, haraken
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Fix leak in InspectorDatabaseAgent. We should stop instrumenting on detach. BUG=604691 Committed: https://crrev.com/8793c4ac3ab093d2cc73624dfc4828e0a58be6b7 Cr-Commit-Position: refs/heads/master@{#388266}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dgozman
Take a look please.
4 years, 8 months ago (2016-04-19 17:26:27 UTC) #2
pfeldman
lgtm
4 years, 8 months ago (2016-04-19 17:40:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893203004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893203004/1
4 years, 8 months ago (2016-04-19 17:41:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 19:12:43 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:14:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8793c4ac3ab093d2cc73624dfc4828e0a58be6b7
Cr-Commit-Position: refs/heads/master@{#388266}

Powered by Google App Engine
This is Rietveld 408576698