Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 1893173002: X87: Bugfix: assert in lithium compile for LMaybeGrowElements. (Closed)

Created:
4 years, 8 months ago by zhengxing.li
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Bugfix: assert in lithium compile for LMaybeGrowElements. port ce1fe78d7e7d8b45d56bcab4cea1d3eab6dcfc79 (r35331) original commit message: BUG= Committed: https://crrev.com/4035d55c0c7090237371b39bffaffc91b61005b7 Cr-Commit-Position: refs/heads/master@{#35554}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 8 months ago (2016-04-17 15:27:18 UTC) #2
Weiliang
lgtm
4 years, 8 months ago (2016-04-17 16:00:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893173002/1
4 years, 8 months ago (2016-04-18 01:50:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 02:11:56 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 02:12:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4035d55c0c7090237371b39bffaffc91b61005b7
Cr-Commit-Position: refs/heads/master@{#35554}

Powered by Google App Engine
This is Rietveld 408576698