Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1893143002: Remove libxml from google_apis dependencies. (Closed)

Created:
4 years, 8 months ago by dominicc (has gone to gerrit)
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove libxml from google_apis dependencies. BUG=604167 Committed: https://crrev.com/546358bef256d70e9bb3a119c2f90c805ac5ff35 Cr-Commit-Position: refs/heads/master@{#388663}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M google_apis/google_apis.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 1846153002 Patch 30001

Messages

Total messages: 8 (3 generated)
dominicc (has gone to gerrit)
Hi Roger, I don't think google_apis depends on libxml, so I'm removing the dependency in ...
4 years, 8 months ago (2016-04-17 12:44:09 UTC) #2
Roger Tawa OOO till Jul 10th
lgtm
4 years, 8 months ago (2016-04-20 15:15:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893143002/1
4 years, 8 months ago (2016-04-21 01:21:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 02:58:43 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:30:26 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/546358bef256d70e9bb3a119c2f90c805ac5ff35
Cr-Commit-Position: refs/heads/master@{#388663}

Powered by Google App Engine
This is Rietveld 408576698