Implement '--gpu-sandbox-failures-nonfatal' flag.

Implement '--gpu-sandbox-failures-nonfatal' flag.

Also, move the flag to content:: instead of chromeos::.

BUG=327824
TEST=Chrome compiles, loads with and without the flag.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255564

[Jorge Lucangeli Obes, 2014-03-06 22:51:18]

Julien: please review.
Antoine: OWNERS review for the flag move.

Thanks!

[jln (very slow on Chromium), 2014-03-06 23:02:29]

Won't this crash on regular Linux?

Also: what do you think of having the reverse flag?
--gpu-sandbox-failures-fatal? (Or a flag that take "=true" or "=false").

It would be nice to be able to fine-tune what happens, regardless of what the
default policy is for the various platforms. (For instance I would use
--gpu-sandbox-failures-fatal on my WS for testing and catching regrssions).

https://codereview.chromium.org/189313002/diff/1/content/common/sandbox_linux...
File content/common/sandbox_linux/sandbox_linux.cc (right):

https://codereview.chromium.org/189313002/diff/1/content/common/sandbox_linux...
content/common/sandbox_linux/sandbox_linux.cc:273: bool sandbox_failure_nonfatal
= false;
So, on non regular Linux, this will crash, no?

nit: My personal preference would be to call it sandbox_failure_fatal, which I
find easier to follow, but your choice.

https://codereview.chromium.org/189313002/diff/1/content/common/sandbox_linux...
content/common/sandbox_linux/sandbox_linux.cc:284: CHECK(false) <<
error_message;
LOG(FATAL) instead?

[piman, 2014-03-06 23:55:54]

lgtm

[Jorge Lucangeli Obes, 2014-03-07 00:29:44]

I'm happy to add the converse (-fatal) flag, but I cannot remove the -nonfatal
flag without changing CrOS first, so I'd rather do it in a follow-up CL.

https://codereview.chromium.org/189313002/diff/1/content/common/sandbox_linux...
File content/common/sandbox_linux/sandbox_linux.cc (right):

https://codereview.chromium.org/189313002/diff/1/content/common/sandbox_linux...
content/common/sandbox_linux/sandbox_linux.cc:273: bool sandbox_failure_nonfatal
= false;
On 2014/03/06 23:02:30, jln wrote:
> So, on non regular Linux, this will crash, no?
> 
> nit: My personal preference would be to call it sandbox_failure_fatal, which I
> find easier to follow, but your choice.

Done. Was halfway done changing the name of the flag.

https://codereview.chromium.org/189313002/diff/1/content/common/sandbox_linux...
content/common/sandbox_linux/sandbox_linux.cc:284: CHECK(false) <<
error_message;
On 2014/03/06 23:02:30, jln wrote:
> LOG(FATAL) instead?

Done.

[jln (very slow on Chromium), 2014-03-07 00:48:58]

lgtm

[Jorge Lucangeli Obes, 2014-03-07 02:13:59]

The CQ bit was checked by jorgelo@chromium.org

[commit-bot: I haz the power, 2014-03-07 02:19:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jorgelo@chromium.org/189313002/40001

[commit-bot: I haz the power, 2014-03-07 02:19:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-07 02:19:31]

Failed to apply patch for content/browser/gpu/gpu_process_host.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file content/browser/gpu/gpu_process_host.cc
  Hunk #3 FAILED at 1099.
  1 out of 3 hunks FAILED -- saving rejects to file
content/browser/gpu/gpu_process_host.cc.rej

Patch:       content/browser/gpu/gpu_process_host.cc
Index: content/browser/gpu/gpu_process_host.cc
diff --git a/content/browser/gpu/gpu_process_host.cc
b/content/browser/gpu/gpu_process_host.cc
index
8c7a8825a0266151a0a8c1dac9b7e472e68b48b9..1b76f2c24ea64e50f1b24cc040abcbe65ee0c62e
100644
--- a/content/browser/gpu/gpu_process_host.cc
+++ b/content/browser/gpu/gpu_process_host.cc
@@ -48,10 +48,6 @@
 #include "ui/gfx/switches.h"
 #endif
 
-#if defined(OS_CHROMEOS)
-#include "chromeos/chromeos_switches.h"
-#endif
-
 #if defined(USE_OZONE)
 #include "ui/ozone/ozone_switches.h"
 #endif
@@ -1093,6 +1089,7 @@ bool GpuProcessHost::LaunchGpuProcess(const std::string&
channel_id) {
     switches::kEnableShareGroupAsyncTextureUpload,
     switches::kGpuStartupDialog,
     switches::kGpuSandboxAllowSysVShm,
+    switches::kGpuSandboxFailuresNonfatal,
     switches::kLoggingLevel,
     switches::kNoSandbox,
     switches::kTestGLLib,
@@ -1102,9 +1099,6 @@ bool GpuProcessHost::LaunchGpuProcess(const std::string&
channel_id) {
 #if defined(OS_MACOSX)
     switches::kEnableSandboxLogging,
 #endif
-#if defined(OS_CHROMEOS)
-    chromeos::switches::kGpuSandboxFailuresNonfatal,
-#endif
 #if defined(USE_AURA)
     switches::kUIPrioritizeInGpuProcess,
 #endif

[Jorge Lucangeli Obes, 2014-03-07 02:49:50]

The CQ bit was checked by jorgelo@chromium.org

[commit-bot: I haz the power, 2014-03-07 02:51:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jorgelo@chromium.org/189313002/60001

[commit-bot: I haz the power, 2014-03-07 05:27:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-07 05:27:22]

Try jobs failed on following builders: linux_chromium_rel, mac_chromium_rel

[Jorge Lucangeli Obes, 2014-03-07 06:10:57]

The CQ bit was checked by jorgelo@chromium.org

[commit-bot: I haz the power, 2014-03-07 06:15:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jorgelo@chromium.org/189313002/60001

[commit-bot: I haz the power, 2014-03-07 09:16:10]

Change committed as 255564

[Michael van Ouwerkerk, 2014-03-07 11:18:16]

A revert of this CL has been created in
https://codereview.chromium.org/189093008/ by mvanouwerkerk@chromium.org.

The reason for reverting is: Looks like this broke Linux ChromiumOS Tests (2):
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2....

[Alexander Potapenko, 2014-03-07 12:07:11]

It also broke content_browsertests on the ASan bots, e.g.:

[ RUN      ]
CrossPlatformAccessibilityBrowserTest.MultipleInheritanceAccessibility2
Xlib:  extension "RANDR" missing on display ":9".
[25884:25884:0307/033533:2200265637:ERROR:proxy_service.cc(1381)]
ProxyConfigService for ChromeOS should be created in
profile_io_data.cc::CreateProxyConfigService and this should be used only for
examples.
[25884:25915:0307/033533:2200294886:WARNING:proxy_service.cc(903)] PAC support
disabled because there is no system implementation
[25921:25921:0307/033533:2200323231:FATAL:sandbox_linux.cc(298)]
InitializeSandbox() called with multiple threads in process gpu-process
[25884:25884:0307/033533:2200352968:FATAL:gpu_process_transport_factory.cc(211)]
Failed to create UI context, but can't use software compositing with browser
threaded compositing. Aborting.