Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1893123002: Revert of [turbofan] Improve lowering of ObjectIs<Type> somewhat. (Closed)

Created:
4 years, 8 months ago by Benedikt Meurer
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Improve lowering of ObjectIs<Type> somewhat. (patchset #1 id:1 of https://codereview.chromium.org/1872143002/ ) Reason for revert: Looking at types in ChangeLowering is generally unsafe. Original issue's description: > [turbofan] Improve lowering of ObjectIs<Type> somewhat. > > If we already know that the input to one of the ObjectIs<Type> nodes is > TaggedPointer, we don't need to perform the Smi check at runtime. > > R=jarin@chromium.org > > Committed: https://crrev.com/4fc4978cee0bb7ad2ae8681a67b7032eba6a7d11 > Cr-Commit-Position: refs/heads/master@{#35368} TBR=jarin@chromium.org,bmeurer@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://crrev.com/d197ba5b0e12e21f902cd241c14e9cce2ad4dd88 Cr-Commit-Position: refs/heads/master@{#35551}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -85 lines) Patch
M src/compiler/change-lowering.cc View 1 chunk +50 lines, -85 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Benedikt Meurer
Created Revert of [turbofan] Improve lowering of ObjectIs<Type> somewhat.
4 years, 8 months ago (2016-04-16 19:00:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893123002/1
4 years, 8 months ago (2016-04-16 19:00:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893123002/1
4 years, 8 months ago (2016-04-16 19:02:27 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-16 19:25:37 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-04-16 19:26:11 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d197ba5b0e12e21f902cd241c14e9cce2ad4dd88
Cr-Commit-Position: refs/heads/master@{#35551}

Powered by Google App Engine
This is Rietveld 408576698