Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Side by Side Diff: net/tools/quic/quic_client_test.cc

Issue 1893083002: Change scoped_ptr to std::unique_ptr in //net. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: scopedptr-net-all: iwyu Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/tools/quic/quic_client_session_test.cc ('k') | net/tools/quic/quic_dispatcher.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/tools/quic/quic_client.h" 5 #include "net/tools/quic/quic_client.h"
6 6
7 #include <dirent.h> 7 #include <dirent.h>
8 #include <stdio.h> 8 #include <stdio.h>
9 9
10 #include "base/strings/string_util.h" 10 #include "base/strings/string_util.h"
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 // exhaustion in long running processes which repeatedly create clients. 58 // exhaustion in long running processes which repeatedly create clients.
59 59
60 // Record initial number of FDs, after creation of EpollServer. 60 // Record initial number of FDs, after creation of EpollServer.
61 EpollServer eps; 61 EpollServer eps;
62 int number_of_open_fds = NumOpenFDs(); 62 int number_of_open_fds = NumOpenFDs();
63 63
64 // Create a number of clients, initialize them, and verify this has resulted 64 // Create a number of clients, initialize them, and verify this has resulted
65 // in additional FDs being opened. 65 // in additional FDs being opened.
66 const int kNumClients = 50; 66 const int kNumClients = 50;
67 for (int i = 0; i < kNumClients; ++i) { 67 for (int i = 0; i < kNumClients; ++i) {
68 scoped_ptr<QuicClient> client( 68 std::unique_ptr<QuicClient> client(
69 CreateAndInitializeQuicClient(&eps, net::test::kTestPort + i)); 69 CreateAndInitializeQuicClient(&eps, net::test::kTestPort + i));
70 70
71 // Initializing the client will create a new FD. 71 // Initializing the client will create a new FD.
72 EXPECT_LT(number_of_open_fds, NumOpenFDs()); 72 EXPECT_LT(number_of_open_fds, NumOpenFDs());
73 } 73 }
74 74
75 // The FDs created by the QuicClients should now be closed. 75 // The FDs created by the QuicClients should now be closed.
76 EXPECT_EQ(number_of_open_fds, NumOpenFDs()); 76 EXPECT_EQ(number_of_open_fds, NumOpenFDs());
77 } 77 }
78 78
79 TEST(QuicClientTest, CreateAndCleanUpUDPSockets) { 79 TEST(QuicClientTest, CreateAndCleanUpUDPSockets) {
80 // Create a ProofVerifier before counting the number of open FDs to work 80 // Create a ProofVerifier before counting the number of open FDs to work
81 // around some ASAN weirdness. 81 // around some ASAN weirdness.
82 delete CryptoTestUtils::ProofVerifierForTesting(); 82 delete CryptoTestUtils::ProofVerifierForTesting();
83 83
84 EpollServer eps; 84 EpollServer eps;
85 int number_of_open_fds = NumOpenFDs(); 85 int number_of_open_fds = NumOpenFDs();
86 86
87 scoped_ptr<QuicClient> client( 87 std::unique_ptr<QuicClient> client(
88 CreateAndInitializeQuicClient(&eps, net::test::kTestPort)); 88 CreateAndInitializeQuicClient(&eps, net::test::kTestPort));
89 EXPECT_EQ(number_of_open_fds + 1, NumOpenFDs()); 89 EXPECT_EQ(number_of_open_fds + 1, NumOpenFDs());
90 // Create more UDP sockets. 90 // Create more UDP sockets.
91 EXPECT_TRUE(QuicClientPeer::CreateUDPSocketAndBind(client.get())); 91 EXPECT_TRUE(QuicClientPeer::CreateUDPSocketAndBind(client.get()));
92 EXPECT_EQ(number_of_open_fds + 2, NumOpenFDs()); 92 EXPECT_EQ(number_of_open_fds + 2, NumOpenFDs());
93 EXPECT_TRUE(QuicClientPeer::CreateUDPSocketAndBind(client.get())); 93 EXPECT_TRUE(QuicClientPeer::CreateUDPSocketAndBind(client.get()));
94 EXPECT_EQ(number_of_open_fds + 3, NumOpenFDs()); 94 EXPECT_EQ(number_of_open_fds + 3, NumOpenFDs());
95 95
96 // Clean up UDP sockets. 96 // Clean up UDP sockets.
97 QuicClientPeer::CleanUpUDPSocket(client.get(), client->GetLatestFD()); 97 QuicClientPeer::CleanUpUDPSocket(client.get(), client->GetLatestFD());
98 EXPECT_EQ(number_of_open_fds + 2, NumOpenFDs()); 98 EXPECT_EQ(number_of_open_fds + 2, NumOpenFDs());
99 QuicClientPeer::CleanUpUDPSocket(client.get(), client->GetLatestFD()); 99 QuicClientPeer::CleanUpUDPSocket(client.get(), client->GetLatestFD());
100 EXPECT_EQ(number_of_open_fds + 1, NumOpenFDs()); 100 EXPECT_EQ(number_of_open_fds + 1, NumOpenFDs());
101 } 101 }
102 102
103 } // namespace 103 } // namespace
104 } // namespace test 104 } // namespace test
105 } // namespace net 105 } // namespace net
OLDNEW
« no previous file with comments | « net/tools/quic/quic_client_session_test.cc ('k') | net/tools/quic/quic_dispatcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698