Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1893053002: Handle fuzzy optional parameters correctly. (Closed)

Created:
4 years, 8 months ago by Leaf
Modified:
4 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Handle fuzzy optional parameters correctly. Fixes https://github.com/dart-lang/sdk/issues/26156 . Adds translation of known function types in error_verifier.dart to remove uses of dynamic before checking assignability. BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/56ab7bc39a00afeb9d75eb42b931710ca7b451be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -191 lines) Patch
M pkg/analyzer/lib/src/generated/error_verifier.dart View 11 chunks +64 lines, -21 lines 0 comments Download
M pkg/analyzer/lib/src/generated/type_system.dart View 11 chunks +193 lines, -120 lines 0 comments Download
M pkg/analyzer/lib/src/task/strong/checker.dart View 2 chunks +1 line, -50 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/checker_test.dart View 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Leaf
The least upper bound changes in type system are just from sorting the file - ...
4 years, 8 months ago (2016-04-15 23:52:26 UTC) #2
Brian Wilkerson
lgtm
4 years, 8 months ago (2016-04-16 00:01:14 UTC) #3
Leaf
4 years, 8 months ago (2016-04-16 00:31:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
56ab7bc39a00afeb9d75eb42b931710ca7b451be (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698