Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1893033002: Fixes memory leak of async directory lister (Closed)

Created:
4 years, 8 months ago by zra
Modified:
4 years, 8 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : Add unsupported calls #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -23 lines) Patch
M runtime/bin/directory.h View 1 2 7 chunks +18 lines, -6 lines 0 comments Download
M runtime/bin/directory.cc View 1 2 5 chunks +67 lines, -2 lines 0 comments Download
M runtime/bin/directory_patch.dart View 1 chunk +18 lines, -0 lines 0 comments Download
M runtime/bin/directory_unsupported.cc View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download
M runtime/bin/io_natives.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/io_patch.dart View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M sdk/lib/io/directory_impl.dart View 1 2 6 chunks +44 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
zra
4 years, 8 months ago (2016-04-18 17:20:21 UTC) #2
Ivan Posva
https://codereview.chromium.org/1893033002/diff/20001/sdk/lib/io/directory_impl.dart File sdk/lib/io/directory_impl.dart (right): https://codereview.chromium.org/1893033002/diff/20001/sdk/lib/io/directory_impl.dart#newcode256 sdk/lib/io/directory_impl.dart:256: external factory _AsyncDirectoryListerOps(int pointer); ditto. (Needs dart2js patch file.)
4 years, 8 months ago (2016-04-20 05:38:16 UTC) #3
Ivan Posva
LGTM -ip
4 years, 8 months ago (2016-04-20 17:12:51 UTC) #4
zra
https://codereview.chromium.org/1893033002/diff/20001/sdk/lib/io/directory_impl.dart File sdk/lib/io/directory_impl.dart (right): https://codereview.chromium.org/1893033002/diff/20001/sdk/lib/io/directory_impl.dart#newcode256 sdk/lib/io/directory_impl.dart:256: external factory _AsyncDirectoryListerOps(int pointer); On 2016/04/20 05:38:16, Ivan Posva ...
4 years, 8 months ago (2016-04-20 22:13:59 UTC) #5
zra
4 years, 8 months ago (2016-04-21 14:57:07 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
ccfd19bfd775c7cfc400aeda2c08fd821616cc82 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698