Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 1892823002: MIPS64: Fix ChromePublic compile error for mips64el (Closed)

Created:
4 years, 8 months ago by gordanac
Modified:
4 years, 7 months ago
Reviewers:
mdempsky, Sorin Jianu, Nico, gordana.cmiljanovic
CC:
chromium-reviews, rickyz+watch_chromium.org, jln+watch_chromium.org, petar.jovanovic, cpu_(ooo_6.6-7.5), waffles
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MIPS64: Fix ChromePublic compile error for mips64el Plus remove ARCH_CPU_MIPS64_FAMILY. BUG=compile error. TEST=build Chrome Public for MIPS64: export GYP_DEFINES="OS=android target_arch=mips64el chrome_apk_use_chromium_linker=0" build/gyp_chromium ninja -C out/Release chrome_public_apk Committed: https://crrev.com/a43ce6005d3bbd512daa90ed37e0a127aba7f897 Cr-Commit-Position: refs/heads/master@{#390030}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M base/process/launch_posix.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M build/build_config.h View 1 chunk +1 line, -1 line 0 comments Download
M components/update_client/update_query_params.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M sandbox/linux/services/credentials.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/services/syscall_wrappers.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (12 generated)
gordanac
Please take a look.
4 years, 8 months ago (2016-04-15 12:29:28 UTC) #2
gordanac
+cpu Can someone take a look?
4 years, 8 months ago (2016-04-25 10:07:29 UTC) #7
Sorin Jianu
lgtm components/update_client/update_query_params.cc
4 years, 8 months ago (2016-04-25 16:08:14 UTC) #9
Sorin Jianu
Nico, Matthew, can you please take a look at the build and sandbox changes? Thank ...
4 years, 8 months ago (2016-04-26 18:12:35 UTC) #10
mdempsky
lgtm
4 years, 8 months ago (2016-04-26 18:16:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892823002/1
4 years, 8 months ago (2016-04-26 19:07:32 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/173419)
4 years, 8 months ago (2016-04-26 19:17:30 UTC) #15
Nico
lgtm When adding someone mid-review, say "thakis: build/". Yesterday, I just received an email that ...
4 years, 8 months ago (2016-04-26 21:42:04 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892823002/1
4 years, 7 months ago (2016-04-27 09:13:11 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 09:17:19 UTC) #21
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 09:18:35 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a43ce6005d3bbd512daa90ed37e0a127aba7f897
Cr-Commit-Position: refs/heads/master@{#390030}

Powered by Google App Engine
This is Rietveld 408576698