Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1892783002: bpf_dsl: replace scoped_refptr with std::shared_ptr (Closed)

Created:
4 years, 8 months ago by mdempsky
Modified:
4 years, 7 months ago
CC:
chromium-reviews, rickyz+watch_chromium.org, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bpf_dsl: replace scoped_refptr with std::shared_ptr Committed: https://crrev.com/5f0530899db11e8002c35de8748ae621decb42a4 Cr-Commit-Position: refs/heads/master@{#391453}

Patch Set 1 #

Patch Set 2 : git cl try #

Patch Set 3 : fix asan build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -98 lines) Patch
M sandbox/linux/bpf_dsl/bpf_dsl.h View 7 chunks +27 lines, -27 lines 0 comments Download
M sandbox/linux/bpf_dsl/bpf_dsl.cc View 21 chunks +47 lines, -52 lines 0 comments Download
M sandbox/linux/bpf_dsl/bpf_dsl_forward.h View 3 chunks +8 lines, -5 lines 0 comments Download
M sandbox/linux/bpf_dsl/bpf_dsl_impl.h View 4 chunks +4 lines, -5 lines 0 comments Download
M sandbox/linux/bpf_dsl/cons.h View 3 chunks +7 lines, -9 lines 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/baseline_policy.h View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
mdempsky
4 years, 8 months ago (2016-04-15 08:11:11 UTC) #2
jln (very slow on Chromium)
Thanks Matthew! lgtm, sorry for the long delay.
4 years, 8 months ago (2016-04-26 22:39:39 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892783002/1
4 years, 8 months ago (2016-04-26 22:40:55 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/152350)
4 years, 7 months ago (2016-04-26 23:26:35 UTC) #7
jln (very slow on Chromium)
On 2016/04/26 23:26:35, commit-bot: I haz the power wrote: > Dry run: Try jobs failed ...
4 years, 7 months ago (2016-04-28 21:04:36 UTC) #8
mdempsky
On 2016/04/28 21:04:36, jln (very slow on Chromium) wrote: > Looks like linux/seccomp-bpf-helpers/baseline_policy.cc is missing ...
4 years, 7 months ago (2016-05-04 05:39:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892783002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892783002/40001
4 years, 7 months ago (2016-05-04 05:39:35 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-04 05:43:59 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 05:45:33 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5f0530899db11e8002c35de8748ae621decb42a4
Cr-Commit-Position: refs/heads/master@{#391453}

Powered by Google App Engine
This is Rietveld 408576698