Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1113)

Issue 1892673002: VideoTrackRecorder: add support for more codecs on construction (Closed)

Created:
4 years, 8 months ago by mcasas
Modified:
4 years, 8 months ago
Reviewers:
emircan
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

VideoTrackRecorder: add support for more codecs on construction Small CL that moves the |use_vp9| ctor param to a CodecId. This is a step in a series of CLs to add support for H264 to MediaRecorder (see https://crrev.com/1886123002/) BUG=600895 (Wrong, it should say 601636) Committed: https://crrev.com/aac4e4dcc28e183d72344c821bd01a9b55998bac Cr-Commit-Position: refs/heads/master@{#387484}

Patch Set 1 #

Total comments: 4

Patch Set 2 : emircan@ nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -12 lines) Patch
M content/renderer/media/media_recorder_handler.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M content/renderer/media/video_track_recorder.h View 2 chunks +7 lines, -3 lines 0 comments Download
M content/renderer/media/video_track_recorder.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M content/renderer/media/video_track_recorder_unittest.cc View 3 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
mcasas
4 years, 8 months ago (2016-04-14 21:17:44 UTC) #2
mcasas
emircan@ PTAL
4 years, 8 months ago (2016-04-14 21:18:50 UTC) #5
emircan
lgtm % nits. https://codereview.chromium.org/1892673002/diff/1/content/renderer/media/media_recorder_handler.cc File content/renderer/media/media_recorder_handler.cc (right): https://codereview.chromium.org/1892673002/diff/1/content/renderer/media/media_recorder_handler.cc#newcode71 content/renderer/media/media_recorder_handler.cc:71: int codecs_count = video ? arraysize(kVideoCodecs) ...
4 years, 8 months ago (2016-04-14 22:00:10 UTC) #6
mcasas
https://codereview.chromium.org/1892673002/diff/1/content/renderer/media/media_recorder_handler.cc File content/renderer/media/media_recorder_handler.cc (right): https://codereview.chromium.org/1892673002/diff/1/content/renderer/media/media_recorder_handler.cc#newcode71 content/renderer/media/media_recorder_handler.cc:71: int codecs_count = video ? arraysize(kVideoCodecs) : arraysize(kAudioCodecs); On ...
4 years, 8 months ago (2016-04-14 22:14:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892673002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892673002/20001
4 years, 8 months ago (2016-04-14 22:16:01 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/79152)
4 years, 8 months ago (2016-04-14 22:28:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892673002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892673002/20001
4 years, 8 months ago (2016-04-14 23:12:10 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-15 00:06:35 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 00:14:47 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aac4e4dcc28e183d72344c821bd01a9b55998bac
Cr-Commit-Position: refs/heads/master@{#387484}

Powered by Google App Engine
This is Rietveld 408576698