Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 189263019: Keeping newer and older definitions for didActivateCompositor() (Closed)

Created:
6 years, 9 months ago by Sunil Ratnu
Modified:
6 years, 9 months ago
Reviewers:
jamesr, abarth-chromium
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Keeping newer and older definitions for didActivateCompositor() This patch has been added in order to land chromium side patch https://codereview.chromium.org/137893025/ and then in turn land the blink side patch https://codereview.chromium.org/138523003/ We need to keep both the definitions of didActivateCompositor in the blink side to land the chromium side patch. Once the chromium side patch lands, we can remove the old definition (i.e. function with unnecessary argument) and all the corresponding calls to old function from the blink side as well. BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168910

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M public/web/WebWidgetClient.h View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Sunil Ratnu
Hi abarth, This patch has been added in order to land chromium side patch https://codereview.chromium.org/137893025/ ...
6 years, 9 months ago (2014-03-08 12:54:51 UTC) #1
abarth-chromium
This looks like a CL for jamesr
6 years, 9 months ago (2014-03-08 17:32:55 UTC) #2
jamesr
lgtm
6 years, 9 months ago (2014-03-10 19:36:39 UTC) #3
Sunil Ratnu
The CQ bit was checked by sunil.ratnu@samsung.com
6 years, 9 months ago (2014-03-11 06:01:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/189263019/1
6 years, 9 months ago (2014-03-11 06:01:10 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-11 06:02:40 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel
6 years, 9 months ago (2014-03-11 06:02:41 UTC) #7
Sunil Ratnu
The CQ bit was unchecked by sunil.ratnu@samsung.com
6 years, 9 months ago (2014-03-11 09:39:24 UTC) #8
Sunil Ratnu
The CQ bit was checked by sunil.ratnu@samsung.com
6 years, 9 months ago (2014-03-11 09:39:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/189263019/1
6 years, 9 months ago (2014-03-11 09:39:48 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-11 10:50:36 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink
6 years, 9 months ago (2014-03-11 10:50:37 UTC) #12
Sunil Ratnu
The CQ bit was checked by sunil.ratnu@samsung.com
6 years, 9 months ago (2014-03-11 11:05:32 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/189263019/1
6 years, 9 months ago (2014-03-11 11:05:40 UTC) #14
commit-bot: I haz the power
6 years, 9 months ago (2014-03-11 12:10:35 UTC) #15
Message was sent while issue was closed.
Change committed as 168910

Powered by Google App Engine
This is Rietveld 408576698