Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 189263013: Move extensions storage API implementation to src/extensions (Closed)

Created:
6 years, 9 months ago by James Cook
Modified:
6 years, 9 months ago
Reviewers:
Devlin
CC:
chromium-reviews, tim+watch_chromium.org, chromium-apps-reviews_chromium.org, maniscalco+watch_chromium.org, haitaol+watch_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Move extensions storage API implementation to src/extensions This moves the core functionality (frontend, backend and local storage implementations) to src/extensions while leaving Chrome-specific sync storage and managed storage implementations in src/chrome. BUG=348058 TEST=unit_tests *Storage*:*Settings* browser_tests ExtensionSettings* TBR=zea@chromium.org for header file move touching chrome/browser/sync/test/integration/extension_settings_helper.cc Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255901

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase (move_storage) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -2610 lines) Patch
D chrome/browser/extensions/api/storage/leveldb_settings_storage_factory.h View 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/browser/extensions/api/storage/leveldb_settings_storage_factory.cc View 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/browser/extensions/api/storage/local_storage_backend.h View 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/browser/extensions/api/storage/local_storage_backend.cc View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/browser/extensions/api/storage/local_value_store_cache.h View 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/browser/extensions/api/storage/local_value_store_cache.cc View 1 chunk +0 lines, -104 lines 0 comments Download
M chrome/browser/extensions/api/storage/managed_value_store_cache.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/storage/managed_value_store_cache.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/policy_value_store.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/policy_value_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/settings_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/extensions/api/storage/settings_backend.h View 1 chunk +0 lines, -74 lines 0 comments Download
D chrome/browser/extensions/api/storage/settings_backend.cc View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/extensions/api/storage/settings_frontend.h View 1 chunk +0 lines, -100 lines 0 comments Download
D chrome/browser/extensions/api/storage/settings_frontend.cc View 1 chunk +0 lines, -185 lines 0 comments Download
D chrome/browser/extensions/api/storage/settings_frontend_unittest.cc View 1 chunk +0 lines, -293 lines 0 comments Download
D chrome/browser/extensions/api/storage/settings_observer.h View 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/browser/extensions/api/storage/settings_quota_unittest.cc View 1 chunk +0 lines, -597 lines 0 comments Download
D chrome/browser/extensions/api/storage/settings_storage_factory.h View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/extensions/api/storage/settings_storage_quota_enforcer.h View 1 chunk +0 lines, -76 lines 0 comments Download
D chrome/browser/extensions/api/storage/settings_storage_quota_enforcer.cc View 1 chunk +0 lines, -273 lines 0 comments Download
M chrome/browser/extensions/api/storage/settings_sync_unittest.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/storage/settings_sync_util.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/extensions/api/storage/settings_test_util.h View 1 chunk +0 lines, -107 lines 0 comments Download
D chrome/browser/extensions/api/storage/settings_test_util.cc View 1 chunk +0 lines, -164 lines 0 comments Download
M chrome/browser/extensions/api/storage/storage_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/storage_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/storage_api_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/storage/sync_storage_backend.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/storage/sync_value_store_cache.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/storage/sync_value_store_cache.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/storage/syncable_settings_storage.h View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/extensions/api/storage/value_store_cache.h View 1 chunk +0 lines, -57 lines 0 comments Download
D chrome/browser/extensions/api/storage/value_store_cache.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/browser/extensions/api/storage/weak_unlimited_settings_storage.h View 1 chunk +0 lines, -51 lines 0 comments Download
D chrome/browser/extensions/api/storage/weak_unlimited_settings_storage.cc View 1 chunk +0 lines, -73 lines 0 comments Download
M chrome/browser/extensions/data_deleter.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/extension_settings_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 2 chunks +0 lines, -18 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/DEPS View 1 chunk +9 lines, -1 line 0 comments Download
A + extensions/browser/api/storage/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/browser/api/storage/leveldb_settings_storage_factory.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + extensions/browser/api/storage/leveldb_settings_storage_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/browser/api/storage/local_storage_backend.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + extensions/browser/api/storage/local_storage_backend.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + extensions/browser/api/storage/local_value_store_cache.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + extensions/browser/api/storage/local_value_store_cache.cc View 1 chunk +5 lines, -5 lines 0 comments Download
A + extensions/browser/api/storage/settings_backend.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + extensions/browser/api/storage/settings_backend.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + extensions/browser/api/storage/settings_frontend.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + extensions/browser/api/storage/settings_frontend.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + extensions/browser/api/storage/settings_frontend_unittest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
A + extensions/browser/api/storage/settings_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/browser/api/storage/settings_quota_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/browser/api/storage/settings_storage_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/browser/api/storage/settings_storage_quota_enforcer.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/browser/api/storage/settings_storage_quota_enforcer.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/browser/api/storage/settings_test_util.h View 4 chunks +5 lines, -9 lines 0 comments Download
A + extensions/browser/api/storage/settings_test_util.cc View 3 chunks +7 lines, -11 lines 0 comments Download
A + extensions/browser/api/storage/value_store_cache.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/browser/api/storage/value_store_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/browser/api/storage/weak_unlimited_settings_storage.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/browser/api/storage/weak_unlimited_settings_storage.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/extensions.gyp View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
James Cook
Devlin, PTAL. This is mostly a mechanical move with a little bit of #include cleanup. ...
6 years, 9 months ago (2014-03-07 21:21:02 UTC) #1
Devlin
lgtm. It looks like rockot's is in the CQ now - so can I assume ...
6 years, 9 months ago (2014-03-07 22:34:39 UTC) #2
James Cook
I can wait until his lands, or land this independently and do the IDL move ...
6 years, 9 months ago (2014-03-07 22:42:57 UTC) #3
Devlin
On 2014/03/07 22:42:57, James Cook wrote: > I can wait until his lands, or land ...
6 years, 9 months ago (2014-03-07 22:44:00 UTC) #4
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 9 months ago (2014-03-09 16:03:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/189263013/10001
6 years, 9 months ago (2014-03-09 16:03:51 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-09 17:40:25 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=278360
6 years, 9 months ago (2014-03-09 17:40:26 UTC) #8
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 9 months ago (2014-03-10 04:16:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/189263013/10001
6 years, 9 months ago (2014-03-10 04:16:36 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-10 07:20:22 UTC) #11
Message was sent while issue was closed.
Change committed as 255901

Powered by Google App Engine
This is Rietveld 408576698