Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 189263007: Test FeedbackVectorPreservedAcrossRecompiles needs crankshaft (Closed)

Created:
6 years, 9 months ago by mvstanton
Modified:
6 years, 9 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Test FeedbackVectorPreservedAcrossRecompiles needs crankshaft The new test didn't recognize that non-sse2 builds on ia32 would disable crankshaft. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19716

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M test/cctest/test-compiler.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mvstanton
Hi Yang, PTAL
6 years, 9 months ago (2014-03-07 11:00:18 UTC) #1
Yang
On 2014/03/07 11:00:18, mvstanton wrote: > Hi Yang, PTAL LGTM.
6 years, 9 months ago (2014-03-07 11:00:43 UTC) #2
mvstanton
6 years, 9 months ago (2014-03-07 11:01:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19716 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698